Scott Seago
2008-Mar-25 13:47 UTC
[Ovirt-devel] [patch] fix nil (unlimited) quota attribute behavior
This patch fixes quota-limiting behavior for omitted parameters. Proper quota enforcment only restricts resources on those parameters that are specified. If 'memory' ,for example, is left blank, then the quota shouldn't enforce memory limits. Empty strings were throwing off the unit conversion methods, resulting in empty values being reset to 0. Scott -------------- next part -------------- A non-text attachment was scrubbed... Name: nil-quota-values-fix.patch Type: text/x-patch Size: 946 bytes Desc: not available URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20080325/f62462a7/attachment.bin>
Hugh O. Brock
2008-Mar-25 13:58 UTC
[Ovirt-devel] [patch] fix nil (unlimited) quota attribute behavior
On Tue, Mar 25, 2008 at 09:47:32AM -0400, Scott Seago wrote:> This patch fixes quota-limiting behavior for omitted parameters. Proper > quota enforcment only restricts resources on those parameters that are > specified. If 'memory' ,for example, is left blank, then the quota > shouldn't enforce memory limits. Empty strings were throwing off the unit > conversion methods, resulting in empty values being reset to 0. > > Scott> diff --git a/wui/src/app/util/ovirt.rb b/wui/src/app/util/ovirt.rb > index 36fd613..9024333 100644Looks good... ACK --H