Drew Allen
2017-Dec-07 23:07 UTC
[opus] [PATCH] Ensure mapping matrix size is always valid.
Nice! Looks good, thanks! On Thu, Dec 7, 2017 at 3:06 PM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:> See proposed modification to your patch to avoid integer overflows and > work on 16-bit int platforms. > > Jean-Marc > > On 12/04/2017 07:08 PM, Drew Allen wrote: > > Hello, > > > > Attached is a patch that ensures only valid sizes of the mapping matrix > > are accepted. > > > > This patch depends on the most recent [PATCH] Fix memory issues in > > Projection API. > > > > Cheers, > > Drew > > > > > > _______________________________________________ > > opus mailing list > > opus at xiph.org > > http://lists.xiph.org/mailman/listinfo/opus > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20171207/1303b2dd/attachment.html>
Jean-Marc Valin
2017-Dec-07 23:13 UTC
[opus] [PATCH] Ensure mapping matrix size is always valid.
OK, all three patches are in master. Do they address all of the issues raised by Mark? Jean-Marc On 12/07/2017 06:07 PM, Drew Allen wrote:> Nice! Looks good, thanks! > On Thu, Dec 7, 2017 at 3:06 PM Jean-Marc Valin <jmvalin at jmvalin.ca > <mailto:jmvalin at jmvalin.ca>> wrote: > > See proposed modification to your patch to avoid integer overflows and > work on 16-bit int platforms. > > Jean-Marc > > On 12/04/2017 07:08 PM, Drew Allen wrote: > > Hello, > > > > Attached is a patch that ensures only valid sizes of the mapping > matrix > > are accepted. > > > > This patch depends on the most recent [PATCH] Fix memory issues in > > Projection API. > > > > Cheers, > > Drew > > > > > > _______________________________________________ > > opus mailing list > > opus at xiph.org <mailto:opus at xiph.org> > > http://lists.xiph.org/mailman/listinfo/opus > > >
Drew Allen
2017-Dec-07 23:15 UTC
[opus] [PATCH] Ensure mapping matrix size is always valid.
Yes. Thank you Jean-Marc! On Thu, Dec 7, 2017 at 3:13 PM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:> OK, all three patches are in master. Do they address all of the issues > raised by Mark? > > Jean-Marc > > On 12/07/2017 06:07 PM, Drew Allen wrote: > > Nice! Looks good, thanks! > > On Thu, Dec 7, 2017 at 3:06 PM Jean-Marc Valin <jmvalin at jmvalin.ca > > <mailto:jmvalin at jmvalin.ca>> wrote: > > > > See proposed modification to your patch to avoid integer overflows > and > > work on 16-bit int platforms. > > > > Jean-Marc > > > > On 12/04/2017 07:08 PM, Drew Allen wrote: > > > Hello, > > > > > > Attached is a patch that ensures only valid sizes of the mapping > > matrix > > > are accepted. > > > > > > This patch depends on the most recent [PATCH] Fix memory issues in > > > Projection API. > > > > > > Cheers, > > > Drew > > > > > > > > > _______________________________________________ > > > opus mailing list > > > opus at xiph.org <mailto:opus at xiph.org> > > > http://lists.xiph.org/mailman/listinfo/opus > > > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20171207/ad3a8a16/attachment.html>