opus - Apr 2017 - Antw: Re: 2 patches related to silk_biquad_alt() optimization

Hi Ulrich,

As Jean-mark recommended, we created "--enable-check-asm" config
option to
active OPUS_CHECK_ASM macros in the optimization, where the C function is
called inside and the results of C and optimization functions are compared
when encoding/decoding the real audio files.

Thanks,
Linfeng

On Wed, Apr 19, 2017 at 11:46 PM, Ulrich Windl <
Ulrich.Windl at rz.uni-regensburg.de> wrote:
> >>> Linfeng Zhang <linfengz at google.com> schrieb am
19.04.2017 um 18:29 in
> Nachricht
> <CAKoqLCDX3eCUGbnZFvRzhiCV1Mbo2ksbj8K+pcVu60Dvit7WCQ at
mail.gmail.com>:
> > Hi,
> >
> > Attached are 2 patches related to silk_biquad_alt() optimization.
Please
> > review.
>
> Out of curiosity: How do you test "The optimization is bit exact with
C
> function."? Use one example, or use a few random examples, or use a
defined
> test suite? Or is is done per code inspection?
>
> Regards,
> Ulrich
>
> >
> > Thanks,
> > Linfeng Zhang
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20170424/f7f42431/attachment.html>

>>> Linfeng Zhang <linfengz at google.com> schrieb am 25.04.2017
um 01:52 in Nachricht
<CAKoqLCDvAk7eeS-gpmqSHVxp4t-Lzzw7TLo5rRo=Ey_Q==cxGg at
mail.gmail.com>:
> Hi Ulrich,
> 
> As Jean-mark recommended, we created "--enable-check-asm" config
option to
> active OPUS_CHECK_ASM macros in the optimization, where the C function is
> called inside and the results of C and optimization functions are compared
> when encoding/decoding the real audio files.
My question was on the audio files: Considering that different code paths are
used depending on the input material (and possibly also depending on the command
line flags), is there a test suite that exercises all code paths, or do you use
just a random example to check?

Regards,
Ulrich
> 
> Thanks,
> Linfeng
> 
> On Wed, Apr 19, 2017 at 11:46 PM, Ulrich Windl <
> Ulrich.Windl at rz.uni-regensburg.de> wrote:
> 
>> >>> Linfeng Zhang <linfengz at google.com> schrieb am
19.04.2017 um 18:29 in
>> Nachricht
>> <CAKoqLCDX3eCUGbnZFvRzhiCV1Mbo2ksbj8K+pcVu60Dvit7WCQ at
mail.gmail.com>:
>> > Hi,
>> >
>> > Attached are 2 patches related to silk_biquad_alt() optimization.
Please
>> > review.
>>
>> Out of curiosity: How do you test "The optimization is bit exact
with C
>> function."? Use one example, or use a few random examples, or use
a defined
>> test suite? Or is is done per code inspection?
>>
>> Regards,
>> Ulrich
>>
>> >
>> > Thanks,
>> > Linfeng Zhang
>>
>>
>>
>>
>>

>
> My question was on the audio files: Considering that different code paths
> are used depending on the input material (and possibly also depending on
> the command line flags), is there a test suite that exercises all code
> paths, or do you use just a random example to check?
>
I used several speech and music files, but it's not guaranteed that all
code paths are exercised.
We also have local unit test code to generate random inputs for the
optimized functions, which is not included in the patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20170425/3e4b2a69/attachment-0001.html>