opus - Sep 2016 - [PATCH 9/9] Optimize silk_inner_prod_aligned_scale() for ARM NEON

Hi Timothy,

Could you please share your make configuration?

I tested on this morning's master with my first 2 patches with the
following configurations and all work fine.

ARM Fixed-point ./configure --build x86_64-unknown-linux-gnu --host
arm-linux-gnueabihf --enable-fixed-point --enable-intrinsics
CFLAGS='-O3'
--disable-shared
ARM Floating-Point: ./configure --build x86_64-unknown-linux-gnu --host
arm-linux-gnueabihf --enable-intrinsics CFLAGS='-O3' --disable-shared
X86 Fixed-Point: ./configure --enable-fixed-point --enable-intrinsics
CFLAGS='-O3' --disable-shared
X86 Floating-Point: ./configure --enable-intrinsics CFLAGS='-O3'
--disable-shared

Thanks,
Linfeng


On Sun, Sep 4, 2016 at 7:31 AM, Timothy B. Terriberry <tterribe at
xiph.org>
wrote:
> Linfeng Zhang wrote:
>
>> Created corresponding unit test, and the optimization is bit exact with
C
>> function.
>>
>
> How are you building/running these tests? None of the tests (from any of
> the patches starting with the second) build for me on 32-bit ARMv7 with
> --enable-fixed-point, or even on x86. Example errors:
>
>   CCLD     tests/test_unit_optimization
> tests/test_unit_optimization.o: In function `test_fir':
>
/home/derf/src/xiph/git/xiph/opus/build/../celt/tests/test_unit_optimization_lpc.c:58:
> undefined reference to `CELT_FIR_IMPL'
>
/home/derf/src/xiph/git/xiph/opus/build/../celt/tests/test_unit_optimization_lpc.c:65:
> undefined reference to `CELT_FIR_IMPL'
>
/home/derf/src/xiph/git/xiph/opus/build/../celt/tests/test_unit_optimization_lpc.c:77:
> undefined reference to `celt_fir_c'
> tests/test_unit_optimization.o: In function `main':
>
/home/derf/src/xiph/git/xiph/opus/build/../tests/test_unit_optimization.c:51:
> undefined reference to `opus_select_arch'
> collect2: error: ld returned 1 exit status
>
> _______________________________________________
> opus mailing list
> opus at xiph.org
> http://lists.xiph.org/mailman/listinfo/opus
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20160906/5e8b15d4/attachment.html>

Linfeng Zhang wrote:
> Could you please share your make configuration?
For ARMv7, just
./configure --enable-fixed-point

building natively on a Novena (armv7l, Debian Jessie (8.5), gcc 
4.9.2-10, binutils 2.25).

For x86,
./configure --enable-fixed-point --disable-float-api

with gcc 4.9.1, binutils 2.22.
> I tested on this morning's master with my first 2 patches with the
> following configurations and all work fine.
For patches 1..6, I'm using the rebased patches from the zipfile you 
sent on July 26th.

Possibly your use of --disable-shared is the source of the problems?

Hi Timothy,

Thanks for the hint! Yes, --disable-shared is the reason.

Would you please help test the attached patches, which contain all the 11
commits I have finished on ARM NEON optimization so far.

Best,
Linfeng

On Tue, Sep 6, 2016 at 10:04 AM, Timothy B. Terriberry <tterribe at
xiph.org>
wrote:
> Linfeng Zhang wrote:
>
>> Could you please share your make configuration?
>>
>
> For ARMv7, just
> ./configure --enable-fixed-point
>
> building natively on a Novena (armv7l, Debian Jessie (8.5), gcc 4.9.2-10,
> binutils 2.25).
>
> For x86,
> ./configure --enable-fixed-point --disable-float-api
>
> with gcc 4.9.1, binutils 2.22.
>
> I tested on this morning's master with my first 2 patches with the
>> following configurations and all work fine.
>>
>
> For patches 1..6, I'm using the rebased patches from the zipfile you
sent
> on July 26th.
>
> Possibly your use of --disable-shared is the source of the problems?
>
> _______________________________________________
> opus mailing list
> opus at xiph.org
> http://lists.xiph.org/mailman/listinfo/opus
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20160906/3efb51c8/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opus-NEON-11-patches.zip
Type: application/zip
Size: 71375 bytes
Desc: not available
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20160906/3efb51c8/attachment-0001.zip>