opus - Jun 2014 - opus_multistream_encode_float not working in libopus 1.1

>
> This is as expected. The build system is trying to get a git revision
> string out of the source tree to compile in for reference. If you're
> building from a downloaded source .zip, there won't be any git
> information available and it will fall back to the hard-coded release
> string. That's why the error isn't fatal to the build.
Ok, this seems contradictory to the output that the build log is
telling me.  The log is showing a fatal error and the build doesn't
succeed.  There's no compiled lib, dll, or anything.  If I try to
build the entire solution, I get this:

1>------ Build started: Project: silk_common, Configuration: Release
Win32 ------
2>------ Build started: Project: silk_float, Configuration: Release Win32
------
2>  fatal: Not a git repository: 'C:\My Documents\Opus\win32\..\.git'
1>  fatal: Not a git repository: 'C:\My Documents\Opus\win32\..\.git'
1>  The syntax of the command is incorrect.
2>  The syntax of the command is incorrect.
2>  The system cannot find the path specified.
1>  The system cannot find the path specified.
1>C:\Program Files\MSBuild\Microsoft.Cpp\
v4.0\Microsoft.CppCommon.targets(103,5):
error MSB3073: The command ""C:\My
Documents\Opus\win32\VS2010\..\..\win32\genversion.bat" "C:\My
Documents\Opus\win32\VS2010\..\..\win32\version.h" PACKAGE_VERSION
1>C:\Program
Files\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(103,5):
error MSB3073: :VCEnd" exited with code 1.
2>C:\Program
Files\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(103,5):
error MSB3073: The command ""C:\My
Documents\Opus\win32\VS2010\..\..\win32\genversion.bat" "C:\My
Documents\Opus\win32\VS2010\..\..\win32\version.h" PACKAGE_VERSION
2>C:\Program
Files\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(103,5):
error MSB3073: :VCEnd" exited with code 1.
3>------ Build started: Project: celt, Configuration: Release Win32 ------
4>------ Build started: Project: opus, Configuration: Release Win32 ------
4>  fatal: Not a git repository: 'C:\My Documents\Opus\win32\..\.git'
3>  fatal: Not a git repository: 'C:\My Documents\Opus\win32\..\.git'
4>  The syntax of the command is incorrect.
4>  The system cannot find the path specified.
3>  The syntax of the command is incorrect.
3>  The system cannot find the path specified.
4>C:\Program
Files\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(103,5):
error MSB3073: The command ""C:\My
Documents\Opus\win32\VS2010\..\..\win32\genversion.bat" "C:\My
Documents\Opus\win32\VS2010\..\..\win32\version.h" PACKAGE_VERSION
4>C:\Program
Files\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(103,5):
error MSB3073: :VCEnd" exited with code 1.
3>C:\Program
Files\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(103,5):
error MSB3073: The command ""C:\My
Documents\Opus\win32\VS2010\..\..\win32\genversion.bat" "C:\My
Documents\Opus\win32\VS2010\..\..\win32\version.h" PACKAGE_VERSION
3>C:\Program
Files\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(103,5):
error MSB3073: :VCEnd" exited with code 1.
5>------ Build started: Project: silk_fixed, Configuration: Release Win32
------
6>------ Build started: Project: test_opus_api, Configuration: Release
Win32 ------
6>  test_opus_api.c
6>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  apply_sine_window_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  autocorr_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  burg_modified_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  corrMatrix_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  encode_frame_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  find_LPC_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  find_LTP_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  find_pitch_lags_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  find_pred_coefs_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  k2a_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  k2a_Q16_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  LTP_analysis_filter_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  LTP_scale_ctrl_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  noise_shape_analysis_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  pitch_analysis_core_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  prefilter_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  process_gains_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  regularize_correlations_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  residual_energy16_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  residual_energy_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  Compiling...
5>  schur64_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  schur_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  solve_LS_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  vector_ops_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
5>  warped_autocorrelation_FIX.c
5>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
7>------ Build started: Project: opus_demo, Configuration: Release Win32
------
8>------ Build started: Project: test_opus_decode, Configuration:
Release Win32 ------
9>------ Build started: Project: test_opus_encode, Configuration:
Release Win32 ------
8>  test_opus_decode.c
8>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
9>  test_opus_encode.c
9>C:\My Documents\Opus\win32\config.h(43): fatal error C1083: Cannot
open include file: 'version.h': No such file or directory
========== Build: 1 succeeded, 8 failed, 0 up-to-date, 0 skipped =========
It says "1 succeeded" but it also shows "8 failed" and there
aren't
any compiled DLLs or libs.

Are you saying that downloading the git repository is mandatory before
I can compile the downloaded source?  If it is, how do I do that with
git?  Sorry, I've never used git before.

On 2014-06-04 1:25 PM, Alpha Thinktink wrote:
> Ok, this seems contradictory to the output that the build log is
> telling me.  The log is showing a fatal error and the build doesn't
> succeed. 
You're right. Doesn't work on the libopus-1.1 source tarball. Sorry
about that!

 -r

>
> You're right. Doesn't work on the libopus-1.1 source tarball. Sorry
> about that!

Just finally figured out how to download the git package.  Seems to do
it on the git package as well.

I've modified the bat file to exit 0 right away and manually created
the version.h file with the "define" you mentioned earlier and finally
got it to compile opus.dll but only after directing the opus project
to find the lib files by absolute path.  Gonna try to see if I can get
it to run under a debugger but I make no promises.

As a side note:
Every time I try to reply to your responses from the mailing list, it
always wants to reply directly to your mail account instead of the
list.  I have to hit reply all and then delete your e-mail from the
list to get it to send to the list only.

Finally got it to compile and attach the MSVC debugger.

It fails at the following:
    if ((!st->variable_duration && 400*frame_size != st->Fs
&&
200*frame_size != st->Fs && 100*frame_size != st->Fs &&
         50*frame_size != st->Fs &&  25*frame_size != st->Fs
&&
50*frame_size != 3*st->Fs)
         || (400*frame_size < st->Fs)
         || max_data_bytes<=0
         )
    {
       RESTORE_STACK;
       return OPUS_BAD_ARG;
    }
---inside---
opus_encode_native(...)

---on---
line 970 inside opus_encoder.c

---where the debugger says---
!st->variable_duration evaluates as false
400*frame_size != st->Fs evaluates as true
200*frame_size != st->Fs evaluates as true
100*frame_size != st->Fs evaluates as true
50*frame_size != st->Fs evaluates as false
25*frame_size != st->Fs evaluates as true
50*frame_size != 3*st->Fs evaluates as true
(400*frame_size < st->Fs) evaluates as true
max_data_bytes<=0 evaluates as true

---variables values involved---
st->variable_duration=5000
frame_size=960
st->Fs=48000
max_data_bytes=-11


Hope that helps.