opus\silk\enc_API.c
silk_Encode()
168:
if( ( ret = check_control_input( encControl ) != 0 ) ) {
priority of the '!=' operator is higher than '=' operator
fix:
if( ( ret = check_control_input( encControl ) ) != 0 ) {
Jean-Marc Valin
2014-Feb-06 22:46 UTC
[opus] Bug in getting result of check_control_input()
Thanks for reporting this. It's definitely an error in the code and I just applied the fix you suggested. That being said, I checked and given the way that code is used, it could not have caused any problems since all the code really cares about is zero vs non-zero. Cheers, Jean-Marc On 01/31/2014 05:00 PM, maks wrote:> opus\silk\enc_API.c > silk_Encode() > > 168: > if( ( ret = check_control_input( encControl ) != 0 ) ) { > > priority of the '!=' operator is higher than '=' operator > > fix: > if( ( ret = check_control_input( encControl ) ) != 0 ) { > _______________________________________________ > opus mailing list > opus at xiph.org > http://lists.xiph.org/mailman/listinfo/opus >