Rob Til Freedmen
2009-Feb-26 21:29 UTC
[CELT-dev] celtenc/celtdec does not display CELT_VERSION
A small issue, but missing. Something like this would be helpful: - printf ("celtenc (CELT encoder)\n"); + printf ("celtenc (CELT %s encoder)\n", CELT_VERSION); til
Gregory Maxwell
2009-Feb-26 23:17 UTC
[CELT-dev] celtenc/celtdec does not display CELT_VERSION
On Thu, Feb 26, 2009 at 4:29 PM, Rob Til Freedmen <rob.til.freedman at googlemail.com> wrote:> A small issue, but missing. > Something like this would be helpful: > - ? printf ("celtenc (CELT encoder)\n"); > + ? printf ("celtenc (CELT %s encoder)\n", CELT_VERSION);That is a good point. Perhaps more importantly is the bitstream version, at least to anyone who touches the git repository. I checked in some amendments along these lines into my repository in response to your message. http://git.xiph.org/?p=users/greg/celt.git;a=commit;h=dd91338b0a7ec2a7675a9aaf22a9377c34a10674 So the next version should have something like this. Thanks for the feedback.
torbenh at gmx.de
2009-Mar-08 01:31 UTC
[CELT-dev] celtenc/celtdec does not display CELT_VERSION
On Thu, Feb 26, 2009 at 06:17:15PM -0500, Gregory Maxwell wrote:> On Thu, Feb 26, 2009 at 4:29 PM, Rob Til Freedmen > <rob.til.freedman at googlemail.com> wrote: > > A small issue, but missing. > > Something like this would be helpful: > > - ? printf ("celtenc (CELT encoder)\n"); > > + ? printf ("celtenc (CELT %s encoder)\n", CELT_VERSION); > > That is a good point. Perhaps more importantly is the bitstream > version, at least to anyone who touches the git repository. > > I checked in some amendments along these lines into my repository in > response to your message. > > http://git.xiph.org/?p=users/greg/celt.git;a=commit;h=dd91338b0a7ec2a7675a9aaf22a9377c34a10674 > > So the next version should have something like this.is the bitstream version already meaning something ? iirc its still 0 and does not change even when bitstream changes ? -- torben Hohn http://galan.sourceforge.net -- The graphical Audio language