openssh unix dev - Oct 2024 - openssh 9.9p1

The following alteration needs to be made to loginrec.c in the routine 
record_failed_login()

#ifdef USE_UTMP
 ??????? construct_utmp(&li, &ut);
#endif

It was missing "#ifdef USE_UTMP" which causes an problem if you are
not
using UTMP.

gt

On Mon, 14 Oct 2024, greg tinkler wrote:
> The following alteration needs to be made to loginrec.c in the routine 
> record_failed_login()
> 
> #ifdef USE_UTMP
>  ??????? construct_utmp(&li, &ut);
> #endif
> 
> It was missing "#ifdef USE_UTMP" which causes an problem if you
are not
> using UTMP.
That's not correct, as we need to be able to construct a utmp record for
the /var/log/btmp and turning off just this line will cause random data
from the stack to be written instead.

Does your system really have btmp but not utmp? What are you building on?

-d