openssh unix dev - Jun 2024 - OpenSSH server doesn't log client disconnect without SSH_MSG_DISCONNECT

On Wed, Jun 5, 2024 at 6:03?AM Damien Miller <djm at mindrot.org>
wrote:
> On Sat, 1 Jun 2024, Opty wrote:
> > Indeed I am.
> >
> > What now?
>
> We need to decide whether to promote these log messages to INFO.
>
> > Should PuTTY change its 'perfectly OK to unceremoniously
> > slam the connection shut when you're done' attitude?
>
> I don't think they need to. I think it's fair that we log
connections
> that are terminated regardsless of how graceful the termination was.
> E.g. why shouldn't we log connections that drop because the peer
> process got SIGINT or the TCP connection dropped before sending a
> SSH2_MSG_DISCONNECT?
I will wait for the final verdict then. Thanks for letting me know.

Regards,
Opty

On Wed, Jun 5, 2024 at 3:14?PM Opty <opty77 at gmail.com>
wrote:
> On Wed, Jun 5, 2024 at 6:03?AM Damien Miller <djm at mindrot.org>
wrote:
> > On Sat, 1 Jun 2024, Opty wrote:
> > > Indeed I am.
> > >
> > > What now?
> >
> > We need to decide whether to promote these log messages to INFO.
> >
> > > Should PuTTY change its 'perfectly OK to unceremoniously
> > > slam the connection shut when you're done' attitude?
> >
> > I don't think they need to. I think it's fair that we log
connections
> > that are terminated regardsless of how graceful the termination was.
> > E.g. why shouldn't we log connections that drop because the peer
> > process got SIGINT or the TCP connection dropped before sending a
> > SSH2_MSG_DISCONNECT?
>
> I will wait for the final verdict then. Thanks for letting me know.
I will also try 'LogVerbose serverloop.c:process_input():*' soon which
might do here.

Regards,
Opty