Hi Jim, thanks for the pointer. However, after reading the document it is unclear to me what I should have done differently - can you please give a hint? Is it that I should have used bugzilla? Am 27.01.22 um 20:29 schrieb Jim Knoble:> >> On Jan 27, 2022, at 07:01, Thomas K?ller <thomas at koeller.dyndns.org> wrote: >> >> ?commit 73734a17849bb04a411e6eb29071ecc6dc80efee > [...] >> Include fix >> >> auth.h uses the HostStatus type defined in hostfile.h, which therefore >> has to be included. > [...] >> diff --git a/auth.h b/auth.h >> index a65d8fd0..edac85b2 100644 >> --- a/auth.h >> +++ b/auth.h >> @@ -40,6 +40,8 @@ > [...] > > @Thomas, you'll have more likelihood of your patches being accepted if you follow the [OpenSSH bug reporting process][*], so they can be tracked and assigned to a release. > > [*]: https://www.openssh.com/report.html > _______________________________________________ > openssh-unix-dev mailing list > openssh-unix-dev at mindrot.org > https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
On Fri, 28 Jan 2022 at 07:46, Thomas K?ller <thomas at koeller.dyndns.org> wrote:> thanks for the pointer. However, after reading the document it is > unclear to me what I should have done differently - can you please give > a hint? Is it that I should have used bugzilla? >In this case either is fine. Bugzilla is preferable for anything non-trivial (having all of the context in one place helps, especially if it's something that needs rework, we can't look at for a while or needs tracking over time). For this specific diff: in most cases we put the required includes in the .c file. Is there some case where your change is needed to compile? -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.
Am 27.01.22 um 23:24 schrieb Darren Tucker:> In this case either is fine.? Bugzilla is preferable for anything > non-trivial (having all of the context in one place helps, especially if > it's something that needs rework, we can't look at for a while or needs > tracking over time).I now uploaded the patch series I was working on to bugzilla: https://bugzilla.mindrot.org/show_bug.cgi?id=3384. It also contains the include fixes and therefore I retract this patch and also https://lists.mindrot.org/pipermail/openssh-unix-dev/2022-January/039946.html.