Michael Forney
2021-May-14 01:14 UTC
[PATCH v2 2/2] Remove trailing semicolon after RB_GENERATE_STATIC
This expands to a series of function definitions, so the semicolon is not necessary (in fact, it is not allowed in ISO C). --- krl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/krl.c b/krl.c index 5612e774..c75279f9 100644 --- a/krl.c +++ b/krl.c @@ -61,7 +61,7 @@ struct revoked_serial { }; static int serial_cmp(struct revoked_serial *a, struct revoked_serial *b); RB_HEAD(revoked_serial_tree, revoked_serial); -RB_GENERATE_STATIC(revoked_serial_tree, revoked_serial, tree_entry, serial_cmp); +RB_GENERATE_STATIC(revoked_serial_tree, revoked_serial, tree_entry, serial_cmp) /* Tree of key IDs */ struct revoked_key_id { @@ -70,7 +70,7 @@ struct revoked_key_id { }; static int key_id_cmp(struct revoked_key_id *a, struct revoked_key_id *b); RB_HEAD(revoked_key_id_tree, revoked_key_id); -RB_GENERATE_STATIC(revoked_key_id_tree, revoked_key_id, tree_entry, key_id_cmp); +RB_GENERATE_STATIC(revoked_key_id_tree, revoked_key_id, tree_entry, key_id_cmp) /* Tree of blobs (used for keys and fingerprints) */ struct revoked_blob { @@ -80,7 +80,7 @@ struct revoked_blob { }; static int blob_cmp(struct revoked_blob *a, struct revoked_blob *b); RB_HEAD(revoked_blob_tree, revoked_blob); -RB_GENERATE_STATIC(revoked_blob_tree, revoked_blob, tree_entry, blob_cmp); +RB_GENERATE_STATIC(revoked_blob_tree, revoked_blob, tree_entry, blob_cmp) /* Tracks revoked certs for a single CA */ struct revoked_certs { -- 2.31.1
Damien Miller
2021-Jun-04 06:20 UTC
[PATCH v2 2/2] Remove trailing semicolon after RB_GENERATE_STATIC
thanks - applied as e76069191 On Thu, 13 May 2021, Michael Forney wrote:> This expands to a series of function definitions, so the semicolon is > not necessary (in fact, it is not allowed in ISO C). > --- > krl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/krl.c b/krl.c > index 5612e774..c75279f9 100644 > --- a/krl.c > +++ b/krl.c > @@ -61,7 +61,7 @@ struct revoked_serial { > }; > static int serial_cmp(struct revoked_serial *a, struct revoked_serial *b); > RB_HEAD(revoked_serial_tree, revoked_serial); > -RB_GENERATE_STATIC(revoked_serial_tree, revoked_serial, tree_entry, serial_cmp); > +RB_GENERATE_STATIC(revoked_serial_tree, revoked_serial, tree_entry, serial_cmp) > > /* Tree of key IDs */ > struct revoked_key_id { > @@ -70,7 +70,7 @@ struct revoked_key_id { > }; > static int key_id_cmp(struct revoked_key_id *a, struct revoked_key_id *b); > RB_HEAD(revoked_key_id_tree, revoked_key_id); > -RB_GENERATE_STATIC(revoked_key_id_tree, revoked_key_id, tree_entry, key_id_cmp); > +RB_GENERATE_STATIC(revoked_key_id_tree, revoked_key_id, tree_entry, key_id_cmp) > > /* Tree of blobs (used for keys and fingerprints) */ > struct revoked_blob { > @@ -80,7 +80,7 @@ struct revoked_blob { > }; > static int blob_cmp(struct revoked_blob *a, struct revoked_blob *b); > RB_HEAD(revoked_blob_tree, revoked_blob); > -RB_GENERATE_STATIC(revoked_blob_tree, revoked_blob, tree_entry, blob_cmp); > +RB_GENERATE_STATIC(revoked_blob_tree, revoked_blob, tree_entry, blob_cmp) > > /* Tracks revoked certs for a single CA */ > struct revoked_certs { > -- > 2.31.1 > > _______________________________________________ > openssh-unix-dev mailing list > openssh-unix-dev at mindrot.org > https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev >