openssh unix dev - Apr 2020 - [PATCH] regression of comment extraction in private key file without passphrase

On Sat, 18 Apr 2020, Lo?c wrote:
> Hi,
> 
> In order to help catching those regressions, here is a new regression
> test file.
Thanks for catching my mistake and thanks even more for writing a regression
test. Both the fix and a slightly-tweaked version of your regress test have
been committed.

-d

On 20/04/2020, Damien Miller wrote :
> On Sat, 18 Apr 2020, Lo?c wrote:
>
>> Hi,
>>
>> In order to help catching those regressions, here is a new regression
>> test file.
> Thanks for catching my mistake and thanks even more for writing a
regression
> test. Both the fix and a slightly-tweaked version of your regress test have
> been committed.
>
> -d
You are welcome, I'm happy to help.

Thanks for tweaking the patch, I didn't remember the posix shell syntax
and completely forgot about the "case" syntax to use globing.

For my patch about keeping the number of round, I'm considering writing
a regression test, but I need to extract the number of round from the
private file binary syntax. Is it acceptable to call python script from
a regression shell script ?

Regards

Lo?c

On Thu, 23 Apr 2020 at 07:58, Lo?c <loic at venez.fr> wrote:
[...]
> For my patch about keeping the number of round, I'm considering writing
> a regression test, but I need to extract the number of round from the
> private file binary syntax. Is it acceptable to call python script from
> a regression shell script ?
Unfortunately, no.  The regression tests need to run on an OpenBSD
base system and Python is not part of base.  Could ssh-keygen be made
to output the information you want?

-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.