openssh unix dev - Aug 2019 - [PATCH] regress: fix memleak in snprintftest

Release buffer acquired in test.
---
 openbsd-compat/regress/snprintftest.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/openbsd-compat/regress/snprintftest.c
b/openbsd-compat/regress/snprintftest.c
index 4ca63e18..224ba7c5 100644
--- a/openbsd-compat/regress/snprintftest.c
+++ b/openbsd-compat/regress/snprintftest.c
@@ -47,7 +47,7 @@ int
 main(void)
 {
 	char b[5];
-	char *src;
+	char *src = NULL;
 
 	snprintf(b,5,"123456789");
 	if (b[4] != '\0')
@@ -69,5 +69,7 @@ main(void)
 	if (x_snprintf(b, 1, "%s %d", "hello", 12345) != 11)
 		fail("vsnprintf does not return required length");
 
+	if(src)
+		free(src);
 	return failed;
 }
-- 
2.22.0

Applied thanks, except:

On Mon, 5 Aug 2019 at 16:38, Jitendra Sharma <jitendra.sharma at
intel.com> wrote:
> +       if(src)
> +               free(src);
free(NULL) is defined as a no-op so the test is superfluous and I
omitted it from the commit.

-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.