Markus Schmidt
2019-Apr-25 13:01 UTC
whitespace difference in openssh.8.0/ssh-pkcs11.c vs portable.
To whom it may concern (if any). Function pkcs11_k11_free is indented with tabs in openssh-8.0 (bsd) but indented with space characters in the portable version. /* release a wrapped object */ static void pkcs11_k11_free(void *parent, void *ptr, CRYPTO_EX_DATA *ad, int idx, long argl, void *argp) { - struct pkcs11_key *k11 = ptr; + struct pkcs11_key *k11 = ptr; - debug("%s: parent %p ptr %p idx %d", __func__, parent, ptr, idx); - if (k11 == NULL) - return; - if (k11->provider) - pkcs11_provider_unref(k11->provider); - free(k11->keyid); - free(k11); + debug("%s: parent %p ptr %p idx %d", __func__, parent, ptr, idx); + if (k11 == NULL) + return; + if (k11->provider) + pkcs11_provider_unref(k11->provider); + free(k11->keyid); + free(k11); } Markus
Darren Tucker
2019-Apr-26 08:23 UTC
whitespace difference in openssh.8.0/ssh-pkcs11.c vs portable.
On Thu, 25 Apr 2019 at 23:03, Markus Schmidt <markus at blueflash.cc> wrote:> Function pkcs11_k11_free is indented with tabs in openssh-8.0 (bsd) but > indented with space characters in the portable version.Patch applied, thanks. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.