Darren Tucker
2018-Apr-23 10:01 UTC
build-issue on AIX with openssh-7.7p1 - easy correction! included
On 23 April 2018 at 19:49, Michael Felt <michael at felt.demon.nl> wrote: [...]> run test agent.sh ...[...]> Question: I have not dug into the tests yet. Will copy to a "local" > directory, and not build out of tree and see if that fixes it (as it does > for many other packages). However, just in case it does not - how can I > fast-forward the tests to the "agent" tests?$ make tests SKIP_UNIT=1 LTESTS=agent There's a regress/README.regress that has some more information. (it should work out-of tree, at least some configurations are tested that way regularly). -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.
Michael Felt
2018-Apr-23 12:28 UTC
build-issue on AIX with openssh-7.7p1 - easy correction! included
On 23/04/2018 12:01, Darren Tucker wrote:> On 23 April 2018 at 19:49, Michael Felt <michael at felt.demon.nl> wrote: > [...] >> run test agent.sh ... > [...] >> Question: I have not dug into the tests yet. Will copy to a "local" >> directory, and not build out of tree and see if that fixes it (as it does >> for many other packages). However, just in case it does not - how can I >> fast-forward the tests to the "agent" tests? > $ make tests SKIP_UNIT=1 LTESTS=agent > > There's a regress/README.regress that has some more information. > > (it should work out-of tree, at least some configurations are tested > that way regularly).After reading the README - some feedback - root at x066:[/data/prj/openbsd/openssh/openssh-7.7p1]PATH=../src/openssh-7.7p1/regress:$PATH:. TEST_SHELL=/bin/sh sh test-exec.sh `pwd` agent-timeo> sh: test-exec.sh: 0403-006 Execute permission denied. root at x066:[/data/prj/openbsd/openssh/openssh-7.7p1]chmod u+x ../src/openssh-7.7p1/regress/test-exec.sh root at x066:[/data/prj/openbsd/openssh/openssh-7.7p1]PATH=../src/openssh-7.7p1/regress:$PATH:. TEST_SHELL=/bin/sh sh test-exec.sh `pwd` agent-timeo> not a file: agent-timeout.sh i.e., I needed to add the execute bit to test-exec.sh With -x: root at x066:[/data/prj/openbsd/openssh/openssh-7.7p1]PATH=../src/openssh-7.7p1/regress:$PATH:. TEST_SHELL=/bin/sh sh -x test-exec.sh `pwd` agent-ti> + _POSIX2_VERSION=199209 + export _POSIX2_VERSION + uname -s + 2> /dev/null + [ ! -z? ] + PORT=4242 + [ -x /usr/ucb/whoami ] + whoami + 1> /dev/null 2>& 1 + + whoami USER=root + OBJ=/data/prj/openbsd/openssh/openssh-7.7p1 + [ x/data/prj/openbsd/openssh/openssh-7.7p1 = x ] + [ ! -d /data/prj/openbsd/openssh/openssh-7.7p1 ] + SCRIPT=agent-timeout.sh + [ xagent-timeout.sh = x ] + [ ! -f agent-timeout.sh ] + echo not a file: agent-timeout.sh not a file: agent-timeout.sh + exit 2 - so not finding the script it seems: - after adding the full path to the script, the test starts running. ++++++++ I get as far as: PATH=../src/openssh-7.7p1/regress:$PATH:. TEST_SHELL=/bin/sh sh -x test-exec.sh `pwd` ../src/openssh-7.7p1/regress/agent.sh ... + trace connect via agent using ed25519 key + /data/prj/openbsd/openssh/openssh-7.7p1/ssh-log-wrapper.sh -F /data/prj/openbsd/openssh/openssh-7.7p1/ssh_proxy -i /data/prj/openbsd/openssh/openssh-7.7p1/ed25519-agent.pub -oIdentitiesOnly=yes somehost exit 52 + r=52 + [ 52 -ne 52 ] + trace agent forwarding + /data/prj/openbsd/openssh/openssh-7.7p1/ssh-log-wrapper.sh -A -F /data/prj/openbsd/openssh/openssh-7.7p1/ssh_proxy somehost ssh-add -l + 1> /dev/null 2>& 1 + r=1 + [ 1 -ne 0 ] + fail ssh-add -l via agent fwd failed (exit code 1) ssh-add -l via agent fwd failed (exit code 1) + /data/prj/openbsd/openssh/openssh-7.7p1/ssh-log-wrapper.sh -A -F /data/prj/openbsd/openssh/openssh-7.7p1/ssh_proxy somehost /data/prj/openbsd/openssh/openssh-7.7p1/ssh-log-wrapper.sh -F /data/prj/openbsd/openssh/openssh-7.7p1/ssh_proxy somehost exit 52 + r=255 + [ 255 -ne 52 ] + fail agent fwd failed (exit code 255) agent fwd failed (exit code 255) + 1> /data/prj/openbsd/openssh/openssh-7.7p1/authorized_keys_root + printf cert-authority,principals="estragon" + cat /data/prj/openbsd/openssh/openssh-7.7p1/user_ca_key.pub + trace connect via agent using rsa key + /data/prj/openbsd/openssh/openssh-7.7p1/ssh-log-wrapper.sh -F /data/prj/openbsd/openssh/openssh-7.7p1/ssh_proxy -i /data/prj/openbsd/openssh/openssh-7.7p1/rsa-agent.pub -oCertificateFile=/data/prj/openbsd/openssh/openssh-7.7p1/rsa-agent-cert.pub -oIdentitiesOnly=yes somehost exit 52 + r=255 + [ 255 -ne 52 ] + fail ssh connect with failed (exit code 255) ssh connect with failed (exit code 255) + trace connect via agent using ed25519 key + /data/prj/openbsd/openssh/openssh-7.7p1/ssh-log-wrapper.sh -F /data/prj/openbsd/openssh/openssh-7.7p1/ssh_proxy -i /data/prj/openbsd/openssh/openssh-7.7p1/ed25519-agent.pub -oCertificateFile=/data/prj/openbsd/openssh/openssh-7.7p1/ed25519-agent-cert.pub -oIdentitiesOnly=yes somehost exit 52 + r=255 + [ 255 -ne 52 ] + fail ssh connect with failed (exit code 255) ssh connect with failed (exit code 255) + trace delete all agent keys + ssh-add -D + 1> /dev/null 2>& 1 + r=2 + [ 2 -ne 0 ] + fail ssh-add -D failed: exit code 2 ssh-add -D failed: exit code 2 + trace kill agent + /opt/bin/ssh-agent -k + 1> /dev/null + cleanup + [ 1 -eq 0 ] + echo failed simple agent test failed simple agent test + exit 1 ++++++ As I see it ending with "/opt/bin/ssh-agent -k", is it likely that the test is not calling the correct "ssh-add" command? ++++++ Will dig more later. - Thx for the hints!
Darren Tucker
2018-Apr-23 12:44 UTC
build-issue on AIX with openssh-7.7p1 - easy correction! included
On 23 April 2018 at 22:28, Michael Felt <michael at felt.demon.nl> wrote: [...]> root at x066:[/data/prj/openbsd/openssh/openssh-7.7p1]PATH=../src/openssh-7.7p1/regress:$PATH:. > TEST_SHELL=/bin/sh sh test-exec.sh `pwd` agent-timeo> > sh: test-exec.sh: 0403-006 Execute permission denied. > root at x066:[/data/prj/openbsd/openssh/openssh-7.7p1]chmod u+x > ../src/openssh-7.7p1/regress/test-exec.sh > root at x066:[/data/prj/openbsd/openssh/openssh-7.7p1]PATH=../src/openssh-7.7p1/regress:$PATH:. > TEST_SHELL=/bin/sh sh test-exec.sh `pwd` agent-timeo> > not a file: agent-timeout.sh > > i.e., I needed to add the execute bit to test-exec.shThat should not be necessary since the command "sh" is run with "test-exec.sh" as its first argument, and sh should source it from the current dir. Which make command are you using? And are you doing an in-tree build? I regularly[0] test with AIX native make[1], although not out-of-tree (ie "make test" is run from the top level openssh dir in that case). [0] usually once per release cycle, usually shortly before the release. [1] admittedly it's AIX 5.1's make, at least until I restore my 5.2 installation's failed hard disk. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.