On 13 April 2018 at 08:29, Josh Soref <jsoref at gmail.com> wrote:> Randall S. Becker <rsbecker at nexbridge.com> wrote: >> >> >> -REGRESSTMP = "$(PWD)/regress" >> +REGRESSTMP = `pwd` >> >> tests interop-tests t-exec unit: regress-prep regress-binaries $(TARGETS) > > > It looks like the problem is that pwd is in uppercase, not so much the > distinction between $() and ``.I would not put too much effort into analysing this. I made the original change in https://github.com/openssh/openssh-portable/commit/3fd2d229 with good intentions but there were a number of problems with it, the last of which was discovered just before the release. We decided that we would back it out but given how close to release it was we deferred it. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.
On April 12, 2018 7:14 PM, Darren Tucker wrote:> On 13 April 2018 at 08:29, Josh Soref <jsoref at gmail.com> wrote: > > Randall S. Becker <rsbecker at nexbridge.com> wrote: > >> > >> > >> -REGRESSTMP = "$(PWD)/regress" > >> +REGRESSTMP = `pwd` > >> > >> tests interop-tests t-exec unit: regress-prep regress-binaries > >> $(TARGETS) > > > > > > It looks like the problem is that pwd is in uppercase, not so much the > > distinction between $() and ``. > > I would not put too much effort into analysing this. I made the original > change in > https://github.com/openssh/openssh-portable/commit/3fd2d229 with good > intentions but there were a number of problems with it, the last of which > was discovered just before the release. We decided that we would back it > out but given how close to release it was we deferred it.Is there going to be a 7.7p2? I can't, in good conscience, go forward with 7.7p1 without it passing. Sadly, Randall
On Thu, 12 Apr 2018, Randall S. Becker wrote:> On April 12, 2018 7:14 PM, Darren Tucker wrote: > > On 13 April 2018 at 08:29, Josh Soref <jsoref at gmail.com> wrote: > > > Randall S. Becker <rsbecker at nexbridge.com> wrote: > > >> > > >> > > >> -REGRESSTMP = "$(PWD)/regress" > > >> +REGRESSTMP = `pwd` > > >> > > >> tests interop-tests t-exec unit: regress-prep regress-binaries > > >> $(TARGETS) > > > > > > > > > It looks like the problem is that pwd is in uppercase, not so much the > > > distinction between $() and ``. > > > > I would not put too much effort into analysing this. I made the original > > change in > > https://github.com/openssh/openssh-portable/commit/3fd2d229 with good > > intentions but there were a number of problems with it, the last of which > > was discovered just before the release. We decided that we would back it > > out but given how close to release it was we deferred it. > > Is there going to be a 7.7p2? I can't, in good conscience, go forward with > 7.7p1 without it passing.Not to fix a broken regress test, no. -d
On 13 April 2018 at 09:29, Randall S. Becker <rsbecker at nexbridge.com> wrote: [...]> Is there going to be a 7.7p2? I can't, in good conscience, go forward with > 7.7p1 without it passing.If you have GNU make then running the regress tests with that should work with that (3.81 worked here). I'll send you a link to the rollback commit once we've done it, you can apply that and run your tests. -- Darren Tucker (dtucker at dtucker.net) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.