openssh unix dev - Feb 2018 - User manipulation of tty mode opcodes / IUTF8 incompatibilities

On Mon, Feb 12, 2018 at 2:49 AM, Darren Tucker <dtucker at dtucker.net>
wrote:
> Please try this patch.
Thanks.  I will do so in the next day or two and report back.

-- Nathan

On Mon, Feb 12, 2018 at 3:08 AM, Nathan Anderson
<nathan at anderson-net.com> wrote:
> On Mon, Feb 12, 2018 at 2:49 AM, Darren Tucker <dtucker at
dtucker.net> wrote:
>
>> Please try this patch.
>
> Thanks.  I will do so in the next day or two and report back.
Eh, screw it.  It doesn't take that long to do and I was awake anyway.

I checked out -current, built it without the patch, and verified that
it still failed to connect to this particular server.  Then I applied
the patch, rebuilt, attempted the connection again, and it works
perfectly.  Also, -vvv results in this output, as expected:

    debug3: tty_make_modes: SSH_BUG_UTF8TTYMODE

Thanks.  If this ships in the next release and all of the platforms
that include OpenSSH as a base component adopt it quickly, I will be a
happy man. :-)

-- Nathan

Hi.

A simplified version of that patch has been committed and will be in
the next release:
https://anongit.mindrot.org/openssh.git/commit/?id=8570177195f6a4b3173c0a25484a83641ee3faa6

If you could confirm that the simplified patch still fixes the problem
I'd appreciate it.

Thanks.


On 12 February 2018 at 22:34, Nathan Anderson <nathan at anderson-net.com>
wrote:
> On Mon, Feb 12, 2018 at 3:08 AM, Nathan Anderson
> <nathan at anderson-net.com> wrote:
>
>> On Mon, Feb 12, 2018 at 2:49 AM, Darren Tucker <dtucker at
dtucker.net> wrote:
>>
>>> Please try this patch.
>>
>> Thanks.  I will do so in the next day or two and report back.
>
> Eh, screw it.  It doesn't take that long to do and I was awake anyway.
>
> I checked out -current, built it without the patch, and verified that
> it still failed to connect to this particular server.  Then I applied
> the patch, rebuilt, attempted the connection again, and it works
> perfectly.  Also, -vvv results in this output, as expected:
>
>     debug3: tty_make_modes: SSH_BUG_UTF8TTYMODE
>
> Thanks.  If this ships in the next release and all of the platforms
> that include OpenSSH as a base component adopt it quickly, I will be a
> happy man. :-)
>
> -- Nathan


-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.