On Fri, Feb 17, 2017 at 09:28:52AM +1100, Darren Tucker wrote: [...]> so yeah, ssh-keygen should have probably errored out "unsupported key type".diff --git a/sshkey.c b/sshkey.c index 4768790..f45e239 100644 --- a/sshkey.c +++ b/sshkey.c @@ -89,7 +89,9 @@ static const struct keytype keytypes[] = { { "ssh-ed25519-cert-v01 at openssh.com", "ED25519-CERT", KEY_ED25519_CERT, 0, 1 }, #ifdef WITH_OPENSSL +# ifdef WITH_SSH1 { NULL, "RSA1", KEY_RSA1, 0, 0 }, +# endif { "ssh-rsa", "RSA", KEY_RSA, 0, 0 }, { "ssh-dss", "DSA", KEY_DSA, 0, 0 }, # ifdef OPENSSL_HAS_ECC -- Darren Tucker (dtucker at zip.com.au) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.
On Fri, Feb 17, 2017 at 9:34 AM, Darren Tucker <dtucker at zip.com.au> wrote:> On Fri, Feb 17, 2017 at 09:28:52AM +1100, Darren Tucker wrote: > [...] >> so yeah, ssh-keygen should have probably errored out "unsupported key type".I've just committed this patch and a similar one to fix the usage text in this case. It'll be in the next release (which according to the current plan will likely be the last one to have SSH1 client support. Thanks for the report. $ ssh-keygen -t rsa1 unknown key type rsa1 $ ssh-keygen -? usage: ssh-keygen [-q] [-b bits] [-t dsa | ecdsa | ed25519 | rsa] -- Darren Tucker (dtucker at zip.com.au) GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.
On Fri, Feb 17, 2017 at 01:39:06PM +1100, Darren Tucker wrote:> On Fri, Feb 17, 2017 at 9:34 AM, Darren Tucker <dtucker at zip.com.au> wrote: > > On Fri, Feb 17, 2017 at 09:28:52AM +1100, Darren Tucker wrote: > > [...] > >> so yeah, ssh-keygen should have probably errored out "unsupported key type". > > I've just committed this patch and a similar one to fix the usage text > in this case. It'll be in the next release (which according to the > current plan will likely be the last one to have SSH1 client support. > > Thanks for the report.Thanks for confirming that I hadn't misinterpreted something. Thanks for the fix too although as you say time is short for SSH1 support. Kelly> > $ ssh-keygen -t rsa1 > unknown key type rsa1 > > $ ssh-keygen -? > usage: ssh-keygen [-q] [-b bits] [-t dsa | ecdsa | ed25519 | rsa] > > -- > Darren Tucker (dtucker at zip.com.au) > GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new) > Good judgement comes with experience. Unfortunately, the experience > usually comes from bad judgement.-- Kelly Dunlop kdunlop at guralp.com Guralp Systems Limited http://www.guralp.com