2017-02-05 23:12 GMT+01:00 Michael Stone <mstone at mathom.us>:> > It was probably because of this commit: > > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/sshd.c.diff?r1=1.472&r2=1.473 >Yes here the combination cr and lf is removed.> Which removed support for protocols older than 2 but perhaps failed to > account for the fact that newline had been redefined when using protocol 2. > But as someone else said, give it a few days for a response.Sure. I reacted not to make you hurry, but for me an error in the greeter (as in the whole init and negotiation phase) is crucial. And I think not only my software, but others too. Error's have to be reported as soon as possible, since openssh is widely used a lot and important to many. Thanks a lot, Stef
On Mon, 6 Feb 2017, Stef Bon wrote:> 2017-02-05 23:12 GMT+01:00 Michael Stone <mstone at mathom.us>: > > > > It was probably because of this commit: > > > > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/sshd.c.diff?r1=1.472&r2=1.473Thanks, I've committed a fix.> > Which removed support for protocols older than 2 but perhaps failed to > > account for the fact that newline had been redefined when using protocol 2. > > But as someone else said, give it a few days for a response. > > Sure. I reacted not to make you hurry, but for me an error in the > greeter (as in the whole init and negotiation phase) > is crucial. And I think not only my software, but others too. > Error's have to be reported as soon as possible, since openssh is > widely used a lot and important to many.It's not crucial at all. Clients must be prepared to handle ident strings terminated with \n, since it is what mixed SSHv1/SSHv2 servers typically send (e.g look at the first "if" block in the diff Michael sent). -d
2017-02-06 10:25 GMT+01:00 Damien Miller <djm at mindrot.org>:> On Mon, 6 Feb 2017, Stef Bon wrote: > > It's not crucial at all. Clients must be prepared to handle ident strings > terminated with \n, since it is what mixed SSHv1/SSHv2 servers typically > send (e.g look at the first "if" block in the diff Michael sent). >Yes you are right. This bug is not fatal. But the combination LF (thus without the CR) and SSH2 is still an error right? Stef