openssh unix dev - Jan 2017 - OpenSSH 7.4 p1 still can't be build without patch on Solaris 10

Hi,

OpenSSH 7.4 p1 still can't be build without patch on Solaris 10 (attached).

Pls, may be possible to add conditional compilation/configuration to
avoid manual actions before build? May be, in portable version?

Otherwise seems OpenSSH stops be portable on all platforms.

Thank you,
WBR, Yuri.

-- 
What is the fundamental difference between the programmer and by a fag?
Fag never become five times to free the memory of one object. Fag will
not use two almost identical string libraries in the same project. Fag
will never write to a mixture of C and C ++. Fag will never pass objects
by pointer. Now you know why these two categories so often mentioned
together, and one of them is worse :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 7.4_solaris10_build_issue.patch
Type: text/x-patch
Size: 864 bytes
Desc: not available
URL:
<http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20170115/30bfe8e1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0x613DEC46.asc
Type: application/pgp-keys
Size: 2437 bytes
Desc: not available
URL:
<http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20170115/30bfe8e1/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20170115/30bfe8e1/attachment-0002.bin>

On Mon, Jan 16, 2017 at 2:34 AM, Yuri Voinov <yvoinov at gmail.com>
wrote:
> OpenSSH 7.4 p1 still can't be build without patch on Solaris 10
(attached).
What does it do (or not)?  We test on an x86 Solaris 10 VM an it built on that.
> -dnl Wide character support.  Linux man page says it needs _XOPEN_SOURCE.
> -saved_CFLAGS="$CFLAGS"
> -CFLAGS="$CFLAGS -D_XOPEN_SOURCE"
> +dnl Wide character support.
> AC_CHECK_FUNCS([mblen mbtowc nl_langinfo wcwidth])
> -CFLAGS="$saved_CFLAGS"
That will break wide character detection on Linux.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.

Darren Tucker wrote:
> On Mon, Jan 16, 2017 at 2:34 AM, Yuri Voinov <yvoinov at gmail.com>
wrote:
>> OpenSSH 7.4 p1 still can't be build without patch on Solaris 10
(attached).
> What does it do (or not)?  We test on an x86 Solaris 10 VM an it built on
that.
>
>> -dnl Wide character support.  Linux man page says it needs
_XOPEN_SOURCE.
>> -saved_CFLAGS="$CFLAGS"
>> -CFLAGS="$CFLAGS -D_XOPEN_SOURCE"
>> +dnl Wide character support.
>> AC_CHECK_FUNCS([mblen mbtowc nl_langinfo wcwidth])
>> -CFLAGS="$saved_CFLAGS"
> That will break wide character detection on Linux.
>
It builds (and works) fine on Solaris 10 for SPARC as well.

--
Jeff Wieland, UNIX/Network Systems Administrator
Purdue University IT Infrastructure Services UNIX Platforms

16.01.2017 4:03, Darren Tucker ?????:
> On Mon, Jan 16, 2017 at 2:34 AM, Yuri Voinov <yvoinov at gmail.com>
wrote:
>> OpenSSH 7.4 p1 still can't be build without patch on Solaris 10
(attached).
> What does it do (or not)?  We test on an x86 Solaris 10 VM an it built on
that.
With -m64. To produce 64 bit binaries. Try to build 64 bit. On 64-bit 
OSes we're always build 64-bit binaries, right?
>
>> -dnl Wide character support.  Linux man page says it needs
_XOPEN_SOURCE.
>> -saved_CFLAGS="$CFLAGS"
>> -CFLAGS="$CFLAGS -D_XOPEN_SOURCE"
>> +dnl Wide character support.
>> AC_CHECK_FUNCS([mblen mbtowc nl_langinfo wcwidth])
>> -CFLAGS="$saved_CFLAGS"
That will break wide character detection on Linux.
Well, is it too diffucult to differentiate OS and kernel?

Hi.

On Mon, Jan 16, 2017 at 9:03 AM, Darren Tucker <dtucker at zip.com.au>
wrote:
> On Mon, Jan 16, 2017 at 2:34 AM, Yuri Voinov <yvoinov at gmail.com>
wrote:
>> OpenSSH 7.4 p1 still can't be build without patch on Solaris 10
(attached).
>
> What does it do (or not)?  We test on an x86 Solaris 10 VM an it built on
that.
>
>> -dnl Wide character support.  Linux man page says it needs
_XOPEN_SOURCE.
>> -saved_CFLAGS="$CFLAGS"
>> -CFLAGS="$CFLAGS -D_XOPEN_SOURCE"
>> +dnl Wide character support.
>> AC_CHECK_FUNCS([mblen mbtowc nl_langinfo wcwidth])
>> -CFLAGS="$saved_CFLAGS"
>
> That will break wide character detection on Linux.
It turns out I was wrong about that.  Your patch has been applied and
will be in the next release.

Thanks.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.