On 2/17/16 6:02 PM, Darren Tucker wrote:> On Thu, Feb 18, 2016 at 12:43 PM, Carson Gaspar <carson at taltos.org> wrote: > [...] >> Is there a sane way to run just one test script? LTESTS can't be overridden >> AFAIK... > > make t-exec LTESTS=testname > > where testname is the name of the specific test script without the .sh > extension.Nope, that runs all of them :-( But "make t-exec SUDO=sudo MAKE='make LTESTS=agent'" works. Or "make t-exec SUDO=sudo LTESTS=agent MAKE='make -e'". I guess your make defaults to Env Vars overriding assignments. How odd ;-) What is agent.sh doing that's trying to invoke sudo with no tty? The failure is easily repeatable, and I doubt it's Solaris specific... -- Carson
On Thu, Feb 18, 2016 at 1:14 PM, Carson Gaspar <carson at taltos.org> wrote: [...]> But "make t-exec SUDO=sudo MAKE='make LTESTS=agent'" works. Or "make t-exec > SUDO=sudo LTESTS=agent MAKE='make -e'". I guess your make defaults to Env > Vars overriding assignments. How odd ;-)err, ok then.> What is agent.sh doing that's trying to invoke sudo with no tty? The failure > is easily repeatable, and I doubt it's Solaris specific...When SUDO is set, test-exec runs sshd as root. I'm not sure which specific thing it's complaining about, though. You could try putting "set -x" in test-exec.sh and see what it's doing around the time of the error. My guess is that it's when ssh is trying to run sshd as a proxycommand: [...[] proxycommand ${SUDO} sh ${SRC}/sshd-log-wrapper.sh ${TEST_SSHD_LOGFILE} ${SSHD} -i -f $OBJ/sshd_proxy Some tests like agent-ptrace use sudo specifically for things like setting permissions bits but that doesn't look like it in your case. -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement
On 2/17/16 6:29 PM, Darren Tucker wrote:> On Thu, Feb 18, 2016 at 1:14 PM, Carson Gaspar <carson at taltos.org> wrote:>> What is agent.sh doing that's trying to invoke sudo with no tty? The failure >> is easily repeatable, and I doubt it's Solaris specific... > > When SUDO is set, test-exec runs sshd as root. I'm not sure which > specific thing it's complaining about, though. You could try putting > "set -x" in test-exec.sh and see what it's doing around the time of > the error. My guess is that it's when ssh is trying to run sshd as a > proxycommand: > > [...[] proxycommand ${SUDO} sh ${SRC}/sshd-log-wrapper.sh > ${TEST_SSHD_LOGFILE} ${SSHD} -i -f $OBJ/sshd_proxyThe actual failure is in: ++ /home/carson/openssh-git/regress/ssh-log-wrapper.sh -A -2 -F /home/carson/openssh-git/regress/ssh_proxy somehost '/home/carson/openssh-git/regress/ssh-log-wrapper.sh -2 -F /home/carson/openssh-git/regress/ssh_proxy somehost exit 52' sudo: no tty present and no askpass program specified My sudo has tty tickets enabled, so I had to go the NOPASSWD route :-( Once I did, all tests pass on Sol 10. -- Carson
On Wed, 17 Feb 2016, Carson Gaspar wrote:> > But "make t-exec SUDO=sudo MAKE='make LTESTS=agent'" works. Or "make t-exec > SUDO=sudo LTESTS=agent MAKE='make -e'". I guess your make defaults to Env Vars > overriding assignments. How odd ;-)I usually use: make LTESTS=agent SKIP_UNIT=1 tests