openssh unix dev - Feb 2016 - Call for testing: OpenSSH 7.2

On Wed, 17 Feb 2016, Hisashi T Fujinaka wrote:
> > I need to make these error messages more user-friendly :(
> > 
> > -24 is SSH_ERR_SYSTEM_ERROR, so it's likely failing to find/load
the
> > key for some reason. I'll make a patch to improve the error
message,
> > but in the meantime you could probably figure out the exact failure
> > using ktrace/ktruss/strace and/or digging errno out of the core file.
> 
> Do I have to fish the actual invocation of test_hostkeys from somewhere
> too?
Probably not, if you ktrace or similar you need only look for the
last failing syscall (probably open) before the output of the error
message.

-d

On Thu, 18 Feb 2016, Damien Miller wrote:
> On Wed, 17 Feb 2016, Hisashi T Fujinaka wrote:
>
>>> I need to make these error messages more user-friendly :(
>>>
>>> -24 is SSH_ERR_SYSTEM_ERROR, so it's likely failing to
find/load the
>>> key for some reason. I'll make a patch to improve the error
message,
>>> but in the meantime you could probably figure out the exact failure
>>> using ktrace/ktruss/strace and/or digging errno out of the core
file.
>>
>> Do I have to fish the actual invocation of test_hostkeys from somewhere
>> too?
>
> Probably not, if you ktrace or similar you need only look for the
> last failing syscall (probably open) before the output of the error
> message.
More stupidity on my part. A "make distclean" fixed things on my
NetBSD-7 box. Unfortunately, the test crashed NetBSD-current.

-- 
Hisashi T Fujinaka - htodd at twofifty.com
BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee

OK, on NetBSD-current:

test_sshbuf:
...................................................................................................
100 tests ok
test_sshkey: ..................................[1]   Segmentation fault (core
dumped) ${V} /home/htodd...
*** Error code 139

Stop.

...

Core was generated by `test_sshkey'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000000000041273e in cert_parse (key=0x7f7ff7b120c0,
certbuf=0x7f7ff7b16200, b=0x7f7ff7b161b0) at sshkey.c:1896
1896                   
key->cert->principals[key->cert->nprincipals++] = principal;
(gdb) bt
#0  0x000000000041273e in cert_parse (key=0x7f7ff7b120c0,
certbuf=0x7f7ff7b16200, b=0x7f7ff7b161b0) at sshkey.c:1896
#1  sshkey_from_blob_internal (b=b at entry=0x7f7ff7b161b0, keyp=keyp at
entry=0x7f7fffff9040, allow_cert=allow_cert at entry=1)
     at sshkey.c:2116
#2  0x000000000041291c in sshkey_from_blob (blob=<optimized out>,
blen=blen at entry=422, keyp=keyp at entry=0x7f7fffff9040)
     at sshkey.c:2147
#3  0x0000000000412a75 in sshkey_read (ret=ret at entry=0x7f7ff7b12080, cpp=cpp
at entry=0x7f7fffff90a0) at sshkey.c:1302
#4  0x0000000000415f5a in sshkey_try_load_public (k=k at entry=0x7f7ff7b12080,
     filename=0x7f7ff7b16070
"/home/htodd/openssh-portable/regress/unittests/sshkey/testdata/rsa_1-cert.pub",
     commentp=commentp at entry=0x0) at authfile.c:314
#5  0x0000000000416712 in sshkey_load_cert (filename=<optimized out>,
keyp=keyp at entry=0x7f7fffffd150) at authfile.c:419
#6  0x0000000000409f9b in sshkey_tests () at
regress/unittests/sshkey/test_sshkey.c:527
#7  0x0000000000405d81 in tests () at regress/unittests/sshkey/tests.c:24
#8  0x000000000042cc4d in main (argc=3, argv=0x7f7fffffd258) at
regress/unittests/test_helper/test_helper.c:162


-- 
Hisashi T Fujinaka - htodd at twofifty.com
BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee