openssh unix dev - Oct 2015 - [Bug 2464] Adding timestamp to debug messages (log.c:do_log)

https://bugzilla.mindrot.org/show_bug.cgi?id=2464

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2741
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2741&action=edit
Changes as suggested.

Diff updated with suggested changes (also, making the timestamp format
ISO8601 compliant).

That said, what's the use case for this?  The timestamps are bulky, and
the only time I'm ever interested in the timing of them is the relative
time, which could be done in a lot less space by printing the number of
seconds since the previous log message.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

On Wed, Oct 28, 2015 at 06:32:16PM -0700, Mark D. Baushke
wrote:
> and the format string "%Y%m%dT%H%M%SZ". I think gmtime() may be
simpler.
The world should live in GMT.  Unfortunately people want their logs
to be consitent on a machine; syslog reports in localtime so we should
report in localtime :-(

-- 

rgds
Stephen

On Thu, Oct 29, 2015 at 12:32 PM, Mark D. Baushke <mdb at juniper.net>
wrote:
> Diff updated with suggested changes (also, making the timestamp format
> ISO8601 compliant).
>
> Hmmm... full IOS8601 compliance would include the timzeone so the format
I don't have a copy of the ISO8601 text, but the wikipedia page says
"If no UTC relation information is given with a time representation,
the time is assumed to be in local time."  Which in this case it is.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.