Gert Doering
2015-Jul-07 14:52 UTC
[PATCH 1/1] paint visual host key with unicode box-drawing characters
Hi, On Tue, Jul 07, 2015 at 04:25:25PM +0200, Roland Mainz wrote:> General comments: > 1. Not all locales use UTF-8 as encoding but can still use the Unicode > characters you use (e.g. GB18030 is a modern example and it's use is > mandated by all software vendors in PRC China). A quick solution is to > use |iconv()| to convert the UTF-8 byte sequences to the local > encoding (see http://svn.nrubsig.org/svn/people/gisburn/code/ucs4towchar_t/ucs4towchar_t.cSo the suggestion is to use another external dependency (and one that updates quite frequently to the great joy of admins everywhere) just to paint some visual sugar which works about as well in ASCII... ... wtf? The whole idea of using UTF8 in a single place inside OpenSSH just for eye candy needs to be burnt in flames. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany gert at greenie.muc.de fax: +49-89-35655025 gert at net.informatik.tu-muenchen.de
Roland Mainz
2015-Jul-07 14:57 UTC
[PATCH 1/1] paint visual host key with unicode box-drawing characters
On Tue, Jul 7, 2015 at 4:52 PM, Gert Doering <gert at greenie.muc.de> wrote:> Hi, > > On Tue, Jul 07, 2015 at 04:25:25PM +0200, Roland Mainz wrote: >> General comments: >> 1. Not all locales use UTF-8 as encoding but can still use the Unicode >> characters you use (e.g. GB18030 is a modern example and it's use is >> mandated by all software vendors in PRC China). A quick solution is to >> use |iconv()| to convert the UTF-8 byte sequences to the local >> encoding (see http://svn.nrubsig.org/svn/people/gisburn/code/ucs4towchar_t/ucs4towchar_t.c > > So the suggestion is to use another external dependency (and one that > updates quite frequently to the great joy of admins everywhere) just > to paint some visual sugar which works about as well in ASCII...Which *external* dependicy ? |iconv()| is part of the POSIX standard since a *long* time and since I wrote the code in the URL above I can say "... stick the openssl license code on the derived code and you're done with it..." (maybe add by email to it so people can complain to me if they find bugs...). ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;)
Gert Doering
2015-Jul-07 15:18 UTC
[PATCH 1/1] paint visual host key with unicode box-drawing characters
Hi, On Tue, Jul 07, 2015 at 04:57:49PM +0200, Roland Mainz wrote:> > So the suggestion is to use another external dependency (and one that > > updates quite frequently to the great joy of admins everywhere) just > > to paint some visual sugar which works about as well in ASCII... > > Which *external* dependicy ? |iconv()| is part of the POSIX standard > since a *long* time and since I wrote the code in the URL above I can > say "... stick the openssl license code on the derived code and you're > done with it..." (maybe add by email to it so people can complain to > me if they find bugs...).I wonder why my BSDs keep installing and upgrading libiconv on me all the time, then... gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany gert at greenie.muc.de fax: +49-89-35655025 gert at net.informatik.tu-muenchen.de