Hello,
I've hit 2 build issues on rhel-7 using the latest portable tree - HEAD
3dfd8d93dfcc69261f5af99df56f3ff598581979
- rijndael.c:1104:7: error: ?Td4? undeclared (first use in this function)
(Td4[(t0 >> 24) ] << 24) ^
^
introduced in commit a1f8110cd5ed818d59b3a2964fab7de76e92c18e
- ./libssh.a(krl.o): In function `ssh_krl_from_blob': krl.c:1007:
undefined reference to `reallocarray'
introduced in commit in 74de254bb92c684cf53461da97f52d5ba34ded80 -
reallocarray() seems to only part of openbsd-5.6 stdlib
Petr
--
Petr Lautrbach
Thanks for the report. On Wed, Dec 10, 2014 at 12:38 AM, Petr Lautrbach <plautrba at redhat.com> wrote:> Hello, > > I've hit 2 build issues on rhel-7 using the latest portable tree - HEAD > 3dfd8d93dfcc69261f5af99df56f3ff598581979 > > - rijndael.c:1104:7: error: ?Td4? undeclared (first use in this function) > (Td4[(t0 >> 24) ] << 24) ^ > ^ >I'll look at this one shortly.> introduced in commit a1f8110cd5ed818d59b3a2964fab7de76e92c18e > > - ./libssh.a(krl.o): In function `ssh_krl_from_blob': krl.c:1007: > undefined reference to `reallocarray' > > introduced in commit in 74de254bb92c684cf53461da97f52d5ba34ded80 - > reallocarray() seems to only part of openbsd-5.6 stdlib >This one should be fixed by commit 642652d280499691c8212ec6b79724b50008ce09 which adds reallocarray to the compat library. -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.
On Wed, Dec 10, 2014 at 1:41 AM, Darren Tucker <dtucker at zip.com.au> wrote:> Thanks for the report. > > On Wed, Dec 10, 2014 at 12:38 AM, Petr Lautrbach <plautrba at redhat.com> > wrote: > >> Hello, >> >> I've hit 2 build issues on rhel-7 using the latest portable tree - HEAD >> 3dfd8d93dfcc69261f5af99df56f3ff598581979 >> >> - rijndael.c:1104:7: error: ?Td4? undeclared (first use in this function) >> (Td4[(t0 >> 24) ] << 24) ^ >> ^ >> > > I'll look at this one shortly. >Looks like this one was in some unused code that is #if 0'ed out in OpenBSD but wasn't in -portable. Should be fixed by 4bfad14ca56f8ae04f418997816b4ba84e2cfc3c which resyncs those parts. Thanks! -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.