The following patch corrects a portablility issue when compiling openssh 6.0p1 on MirOS (aka. mirbsd). The issue is: sftp-server.c: In function `send_statvfs': sftp-server.c:510: error: request for member `val' in something not a structure or union sftp-server.c:510: error: request for member `val' in something not a structure or union The patch is: --- configure.ac.orig 2012-04-19 05:46:38.000000000 -0600 +++ configure.ac 2012-05-03 08:25:49.429260884 -0600 @@ -3236,6 +3236,7 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ #include <sys/types.h> #include <sys/stat.h> +#include <sys/param.h> #ifdef HAVE_SYS_TIME_H # include <sys/time.h> #endif Thanks, Pieter
Dag-Erling Smørgrav
2012-May-03 17:17 UTC
Portablility patch for openssh 6.0p1 configure.ac
Pieter Bowman <bowman at math.utah.edu> writes:> --- configure.ac.orig 2012-04-19 05:46:38.000000000 -0600 > +++ configure.ac 2012-05-03 08:25:49.429260884 -0600 > @@ -3236,6 +3236,7 @@ > AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ > #include <sys/types.h> > #include <sys/stat.h> > +#include <sys/param.h> > #ifdef HAVE_SYS_TIME_H > # include <sys/time.h> > #endif<sys/param.h> includes <sys/types.h> and should always be included before any other headers. DES -- Dag-Erling Sm?rgrav - des at des.no
>> ... >> Pieter Bowman <bowman at math.utah.edu> writes: >> > --- configure.ac.orig 2012-04-19 05:46:38.000000000 -0600 >> > +++ configure.ac 2012-05-03 08:25:49.429260884 -0600 >> > @@ -3236,6 +3236,7 @@ >> > AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ >> > #include <sys/types.h> >> > #include <sys/stat.h> >> > +#include <sys/param.h> >> > #ifdef HAVE_SYS_TIME_H >> > # include <sys/time.h> >> > #endif >> >> <sys/param.h> includes <sys/types.h> and should always be included >> before any other headers. >> ...You are probably correct. However, after examining the full source of OpenSSH, I find that in most cases <sys/types.h> precedes <sys/param.h>. I could generate patches to "fix" all instances, but that might be better for one of the OpenSSH developers to handle. Pieter