openssh unix dev - Mar 2009 - Memory leak in do_ssh2_kex()

Hi guys

Apparently, there is small memory leak in the do_ssh2_kex() routine in sshd.c.
Line 2195 in sshd.c states:
myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS] = list_hostkey_types();

Where list_hostkey_types() returns a pointer allocated by the xstrdup call (line
735). This pointer should be freed in the calling routine do_ssh2_key().
Should I make a patch for this? 
Also, since my previous patch was not according to the your standards, how many
lines of context do you normally want in a patch file?

Thanks!


Met vriendelijke groet
Best regards
Bien ? vous

Miguel SANDERS
ArcelorMittal Gent

UNIX Systems & Storage
IT Supply Western Europe | John Kennedylaan 51
B-9042 Gent

T +32 9 347 3538 | F +32 9 347 4901 | M +32478 805 023
E miguel.sanders at arcelormittal.com
www.arcelormittal.com/gent


**** 
This message and any attachment are confidential, intended solely for the use of
the individual or entity to whom it is addressed and may be protected by
professional secrecy or intellectual property rights.
If you have received it by mistake, or are not the named recipient(s), please
immediately notify the sender and delete the message. You are hereby notified
that any unauthorized use, copying or dissemination of any or all information
contained in this message is prohibited.
Arcelormittal shall not be liable for the message if altered, falsified, or in
case of error in the recipient.
This message does not constitute any right or commitment for ArcelorMittal
except when expressly agreed otherwise in writing in a separate agreement.
****

miguel.sanders at arcelormittal.com wrote:
> Should I make a patch for this?
I think that sounds good.

> Also, since my previous patch was not according to the your
> standards, how many lines of context do you normally want in a
> patch file?
It's not so much about the amount of context. The point is that diff
defaults to "context diff" which is more difficult for most to read
than "unified diff" which requires diff to be run with -u or e.g.
-U 2.

I think I mixed up u and U in the email, sorry for that confusion. :\


//Peter

Trying to send this via home address...
That FTP server isn't a stable solution :)

Grtz

Miguel