openssh unix dev - Sep 2006 - bug(let): openssh v4.3p2 'ok' out-of-box; 'configure' does not survive 'autoreconf'

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

hi,

building OPENSSH v4.3p2 on OSX 10.4.7, all's fine (config, nake, 
install, exec) out-of-the-box. so, to be clear, this is NOT a blocker, 
by any stretch ...

that said, however ...

if, instead of a don't-monkey-with-it build, prior to ./configure, i:

	autoreconf -i -f

then, a subsequent:

	./configure \
	  --prefix=/usr/local/openssh \
	  --sysconfdir=/var/security/ssh_homedir \
	  --mandir=/usr/local/man \
	  --with-pid-dir=/var/run \
	--with-mantype=man \
	--with-privsep-user=nobody \
	--disable-suid-ssh \
	--with-pam \
	--with-random=/dev/urandom \
	--with-md5-passwords \
	--with-zlib=/usr/local \
	--with-ssl-dir=/usr/local/ssl \
	--with-default-path="/usr/local/openssh/bin:/usr/local/openssh/sbin:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin"
\
	--with-tcp-wrappers \
	--with-4in6

fails at:

	...
	checking for daemon... yes
	checking for getpagesize... yes
	checking whether snprintf correctly terminates long strings... yes
	checking whether snprintf can declare const char *fmt... yes
	checking for (overly) strict mkstemp... no
	./configure: line 16377: syntax error near unexpected token `]]'
	./configure: line 16377: `]])'

checking in 'configure':

	...
	16373	else
	16374	  { { echo "$as_me:$LINENO: error: cannot run test program while 
cross compiling
	16375	See \`config.log' for more details." >&5
	16376	echo "$as_me: error: cannot run test program while cross 
compiling
	16377	See \`config.log' for more details." >&2;}
	16378	   { (exit 1); exit 1; }; }
	16379	fi
	16380	]])
	...

stems from, in 'configure.ac':

	1406	dnl see whether mkstemp() requires XXXXXX
	1407	if test "x$ac_cv_func_mkdtemp" = "xyes" ; then
	1408	AC_MSG_CHECKING([for (overly) strict mkstemp])
	1409	AC_RUN_IFELSE(
	1410		[AC_LANG_SOURCE([[
	1411	#include <stdlib.h>
	1412	main() { char template[]="conftest.mkstemp-test";
	1413	if (mkstemp(template) == -1)
	1414		exit(1);
	1415	unlink(template); exit(0);
	1416	}
- ->	1417		]])],
	1418		[
	1419			AC_MSG_RESULT(no)
	1420		],

fyi, re: relevant (all?) my env:

	% autoreconf --version
		autoreconf (GNU Autoconf) 2.60
	
	% glibtoolize --version
		libtoolize (GNU libtool) 1.5.22
	
	% aclocal --version
		aclocal (GNU automake) 1.9.6
	
	% automake --version
		automake (GNU automake) 1.9.6
	
	% sed --version
		GNU sed version 4.1.5
	
	% gcc -v
		Using built-in specs.
		Target: powerpc-apple-darwin8
		Configured with: /private/var/tmp/gcc/gcc-5363.obj~28/src/configure 
- --disable-checking -enable-werror --prefix=/usr --mandir=/share/man 
- --enable-languages=c,objc,c++,obj-c++ 
- --program-transform-name=/^[cg][^.-]*$/s/$/-4.0/ 
- --with-gxx-include-dir=/include/c++/4.0.0 --with-slibdir=/usr/lib 
- --build=powerpc-apple-darwin8 --host=powerpc-apple-darwin8 
- --target=powerpc-apple-darwin8
		Thread model: posix
		gcc version 4.0.1 (Apple Computer, Inc. build 5363)

cheers,

richard

- -- 

/"\
\ /  ASCII Ribbon Campaign
 X   against HTML email, vCards
/ \  & micro$oft attachments

[GPG] OpenMacNews at gmail dot com
fingerprint: 50C9 1C46 2F8F DE42 2EDB  D460 95F7 DDBD 3671 08C6
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iEYEARECAAYFAkUSmi0ACgkQlffdvTZxCMaOcgCfQggj9JCFPbYw8Bh2lkNNyk5d
t/kAoIRm11Ipxt3zOJBI6ND61mnT3gp7
=x/TY
-----END PGP SIGNATURE-----

On Thu, Sep 21, 2006 at 06:56:59AM -0700, OpenMacNews
wrote:
> building OPENSSH v4.3p2 on OSX 10.4.7, all's fine (config, nake, 
> install, exec) out-of-the-box. so, to be clear, this is NOT a blocker, 
> by any stretch ...
> 
> that said, however ...
> 
> if, instead of a don't-monkey-with-it build, prior to ./configure, i:
> 
> 	autoreconf -i -f
[...]
> stems from, in 'configure.ac':
> 
> 	1406	dnl see whether mkstemp() requires XXXXXX
> 	1407	if test "x$ac_cv_func_mkdtemp" = "xyes" ; then
> 	1408	AC_MSG_CHECKING([for (overly) strict mkstemp])
> 	1409	AC_RUN_IFELSE(
> 	1410		[AC_LANG_SOURCE([[
> 	1411	#include <stdlib.h>
> 	1412	main() { char template[]="conftest.mkstemp-test";
> 	1413	if (mkstemp(template) == -1)
> 	1414		exit(1);
> 	1415	unlink(template); exit(0);
> 	1416	}
> - ->	1417		]])],
> 	1418		[
> 	1419			AC_MSG_RESULT(no)
> 	1420		],
Thanks, I believe this was caused by a missing bracket elsewhere that has
already been fixed (configure.ac rev 1.343).  Autoconf 2.59 didn't care
but 2.60 does.

Index: configure.ac
==================================================================RCS file:
/usr/local/src/security/openssh/cvs/openssh/configure.ac,v
retrieving revision 1.342
retrieving revision 1.343
diff -u -p -r1.342 -r1.343
--- configure.ac	24 Jun 2006 02:10:07 -0000	1.342
+++ configure.ac	27 Jun 2006 01:20:29 -0000	1.343
@@ -1623,6 +1623,7 @@ main(void)
 			AC_MSG_RESULT(no)
 			AC_DEFINE(BROKEN_GETADDRINFO)
 		],
+		[
 			AC_MSG_RESULT(cross-compiling, assuming no)
 		]
 	)

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

hi darren,

- -- On September 22, 2006 12:06:53 AM +1000  Darren Tucker 
<dtucker at zip.com.au> wrote:
>> 	autoreconf -i -f
> [...]
>> stems from, in 'configure.ac':
...
>> - ->	1417		]])],
> Thanks, I believe this was caused by a missing bracket elsewhere that
> has already been fixed (configure.ac rev 1.343).  Autoconf 2.59
> didn't care but 2.60 does.
1st, yes i _have_ upgraded recently from autoconf 2.59 -> 2.60.

2nd, i can confirm that the fix '@@ -1623,6 +1623,7', per prior post, 
does the trick: openssh 4.3p2+autoconf2.60's 
configure/make/install/exec are, now, 'OK'.
> BTW we're currently preparing for the 4.4 release, so it would 
probably be
> better to test a snapshot
and, building:

	SNAP-20060921

on OSX 10.4.7 (per my earlier post of env ...) *with*:

	autoreconf -i -f

results in an error-free build of:

	ssh -V
		OpenSSH_4.4p1-snap20060921, OpenSSL 0.9.8c 05 Sep 2006

which, so far, seems to be 'behaving itself' ...

thx!

cheers,

richard

- -- 

/"\
\ /  ASCII Ribbon Campaign
 X   against HTML email, vCards
/ \  & micro$oft attachments

[GPG] OpenMacNews at gmail dot com
fingerprint: 50C9 1C46 2F8F DE42 2EDB  D460 95F7 DDBD 3671 08C6
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iEYEARECAAYFAkUSruUACgkQlffdvTZxCMaNJACdFPcNn9gQit7nPS5HfKgoEW/C
vU8AniyWdulIDyGeSyojI535bZJQTuRK
=4jwv
-----END PGP SIGNATURE-----