openssh unix dev - Jun 2002 - [Bug 145] sshd fails to increment AIX login failed counter

http://bugzilla.mindrot.org/show_bug.cgi?id=145





------- Additional Comments From dtucker at zip.com.au  2002-06-21 23:43 -------
Created an attachment (id=116)
Merge all previous patches and diff against -cvs




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=145





------- Additional Comments From dtucker at zip.com.au  2002-06-21 23:56 -------
I think I get it now: loginfailed() isn't called until the number of
failures
for a given child process is greater than AUTH_FAIL_MAX (currently defined as 
6). Since ssh gives up after 3 password attempts (plus a couple of public-key?),
loginfailed is never called and the counter is never incremented. Reconnecting 
to sshd gives a new child and the count starts again. Repeat.

I've tested the above patch and confirmed working lockout with it (and lack 
thereof without) on AIX 4.3.3 ML0.

The code deleted from auth[12].c was marked with /* XXX: privsep */ but I'm
not
sure what this indicates. Clues?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=145





------- Additional Comments From mouring at eviladmin.org  2002-07-05 04:11
-------
Applied.  Reopen w/ new patch if more problems are found.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=145

mouring at eviladmin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From mouring at eviladmin.org  2002-07-05 04:12
-------
Applied.  Reopen w/ new patch if more problems are found.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=145

berry.perzon at nogui.se changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |berry.perzon at nogui.se



------- Additional Comments From berry.perzon at nogui.se  2002-07-10 19:27
-------
*** Bug 349 has been marked as a duplicate of this bug. ***



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.