openssh unix dev - Jun 2002 - [Bug 261] AIX capabilities + port-aix.c cleanup

http://bugzilla.mindrot.org/show_bug.cgi?id=261

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|other                       |AIX



------- Additional Comments From dtucker at zip.com.au  2002-06-06 21:22 -------
I finally got a chance to try this. I got compile errors with gcc on AIX 4.2.1 
and 4.3.3.

gcc -g -O2 -Wall -Wpointer-arith -Wno-uninitialized -I. -I.. 
-I/usr/local/include -DHAVE_CONFIG_H -c port-aix.c
port-aix.c: In function `set_limits_from_userattr':
port-aix.c:35: too few arguments to function `setpcred'
port-aix.c:36: too few arguments to function `setpenv'

The following patch works for me.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=261





------- Additional Comments From dtucker at zip.com.au  2002-06-06 21:25 -------
Created an attachment (id=107)
Add extra params to setpcred and setpenv




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=261





------- Additional Comments From dtucker at zip.com.au  2002-06-07 17:55 -------
Created an attachment (id=109)
Merge three previous patches.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=261





------- Additional Comments From janfrode at parallab.uib.no  2002-06-07 19:53
-------
Created an attachment (id=110)
removed setpenv call




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=261





------- Additional Comments From janfrode at parallab.uib.no  2002-06-07 19:55
-------
Two things...

We should probably fail if it fails:

        if (setpcred (user, NULL))
                fatal("Failed to set AIX process credentials.");

and I'm a bit uncertain about the call to setpenv(). I think it does a
bit too much, and with the PENV_INIT it breaks sftp and it doesn't
manage to set the TERM correctly . The effect of calling setpenv() is
that various user environment variables are set up _and_ the user is
given his shell. I think we should just remove the call to setpenv().

Fixed patch attachment above this message..


  -jf



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=261





------- Additional Comments From mouring at eviladmin.org  2002-06-08 00:51
-------
I'd like to make a single commit to resolve this.  Can someone at IBM or 
someone verify this is the correct way to resolve the code?


- Ben



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=261





------- Additional Comments From genty at us.ibm.com  2002-06-14 05:34 -------
I investigated the use of setpcred().  This call is what should be used in 
port-aix.c.  The setpenv() should not be used. 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=261





------- Additional Comments From mouring at eviladmin.org  2002-06-14 05:55
-------
Created an attachment (id=114)
Would the following be acceptable version of this patch?




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=261





------- Additional Comments From dtucker at zip.com.au  2002-06-15 23:33 -------
Worked on my test box (AIX 4.3.3). Patch had HTML LT/GT mangling and missing 
line continuation in configure.ac which required fixing by hand.

+       setrlimit setsid setpcred setvbuf sigaction sigvec snprintf \
+       socketpair strerror strlcat strlcpy strmode strsep sysconf tcgetpgrp \
+       truncate utimes vhangup vsnprintf waitpid __b64_ntop _getpty)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=261

mouring at eviladmin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From mouring at eviladmin.org  2002-06-21 10:03
-------
Commited fix.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.