openssh unix dev - Jan 2002 - [PATCH] Add scp -1 and -2 options to OpenSSH-3.0.2p1

> Here is a patch to add the missing scp -1 and -2 options to eliminate
> confusion for users familiar with the commercial version of SSH.
> 
> This patch and others are maintained on the secure nfs (SNFS) web page:
> http://www.math.ualberta.ca/imaging/snfs/
> 
> -- John Bowman
> University of Alberta
> 
> diff -ur openssh-3.0.2p1/scp.c openssh-3.0.2p1J2/scp.c
> --- openssh-3.0.2p1/scp.c	Sun Oct 21 18:53:59 2001
> +++ openssh-3.0.2p1J2/scp.c	Sat Jan 19 15:26:34 2002
> @@ -82,6 +82,7 @@
>  #include "pathnames.h"
>  #include "log.h"
>  #include "misc.h"
> +#include "compat.h"
>  
Why are we adding compat.h?

>  #ifdef HAVE___PROGNAME
>  extern char *__progname;
> @@ -242,9 +243,15 @@
>  	addargs(&args, "-oClearAllForwardings yes");
>  
>  	fflag = tflag = 0;
> -	while ((ch = getopt(argc, argv, "dfprtvBCc:i:P:q46S:o:F:")) !=
-1)
> +	while ((ch = getopt(argc, argv, "dfprtvBCc:i:P:q1246S:o:F:"))
!= -1)
>  		switch (ch) {
>  		/* User-visible flags. */
> +		case '1':
> +			addargs(&args, "-oProtocol=1");
> +			break;
> +		case '2':
> +			addargs(&args, "-oProtocol=2");
> +			break;
The above could be cleaned up to be:

		case '1':
		case '2':
			addargs(&args, "-Protocol=%c", ch)
			break;

Still doubtful it will be accepted since -o provides such abilities. And
is even stated in the scp documentation as an exmaple of the -o usage.

- Ben

Here is a patch to add the missing scp -1 and -2 options to eliminate
confusion for users familiar with the commercial version of SSH.

This patch and others are maintained on the secure nfs (SNFS) web page:
http://www.math.ualberta.ca/imaging/snfs/

-- John Bowman
University of Alberta

diff -ur openssh-3.0.2p1/scp.c openssh-3.0.2p1J2/scp.c
--- openssh-3.0.2p1/scp.c	Sun Oct 21 18:53:59 2001
+++ openssh-3.0.2p1J2/scp.c	Sat Jan 19 15:26:34 2002
@@ -82,6 +82,7 @@
 #include "pathnames.h"
 #include "log.h"
 #include "misc.h"
+#include "compat.h"
 
 #ifdef HAVE___PROGNAME
 extern char *__progname;
@@ -242,9 +243,15 @@
 	addargs(&args, "-oClearAllForwardings yes");
 
 	fflag = tflag = 0;
-	while ((ch = getopt(argc, argv, "dfprtvBCc:i:P:q46S:o:F:")) != -1)
+	while ((ch = getopt(argc, argv, "dfprtvBCc:i:P:q1246S:o:F:")) != -1)
 		switch (ch) {
 		/* User-visible flags. */
+		case '1':
+			addargs(&args, "-oProtocol=1");
+			break;
+		case '2':
+			addargs(&args, "-oProtocol=2");
+			break;
 		case '4':
 		case '6':
 		case 'C':
@@ -966,7 +973,7 @@
 usage()
 {
 	(void) fprintf(stderr,
-	    "usage: scp [-pqrvBC46] [-F config] [-S ssh] [-P port] [-c cipher]
[-i identity]\n"
+	    "usage: scp [-pqrvBC1246] [-F config] [-S ssh] [-P port] [-c cipher]
[-i identity]\n"
 	    "           [-o option] f1 f2\n"
 	    "   or: scp [options] f1 ... fn directory\n");
 	exit(1);

Personally, I wish it was in the current release as it'd greatly aid our
migration efforts (from a poorly done 2.5.1 implementation) and is a lot
easier to communigate to clueless users.

We've finally managed to piggyback a real ssh deployment onto a high profile
project, and some of the user education is really sucking.

Thanks,
--Jason Lacoss-Arnold, Systems Technical Specialist
Technical Services - Unix Arch.
314-955-8501


-----Original Message-----
From: mouring [mailto:mouring at etoh.eviladmin.org]
Sent: Monday, January 28, 2002 9:48
To: Wichert Akkerman
Cc: openssh-unix-dev at mindrot.org
Subject: Re: [PATCH] Add scp -1 and -2 options to OpenSSH-3.0.2p1

> Previously Markus Friedl wrote:
> > why do you need -1 and -2?
> 
> Users want it, and it's very useful in situations where you need
> to specifiy the version due to existing keys, old servers, etc.
> 
#1 - OpenSSH/OpenBSD is not Debian.  What you do to the source is your 
business, but you only add to the confusion (if there is any at all).  

#2 - In TWO years of helping people with ssh compiling, configuring, and
using.  I've seen SIX people (80% of them are on this list!) whine about
lack of -1/-2.  The others where happy to use -oProtocol=[12] to do their
job.

NOW please.. tell me.. *WHERE* are these MASSES of people crying out for
the -1/-2 option for scp?  SIX people out of almost a thousand plus
people I've interacted with.

<sigh>  Waste of time..

- Ben
_______________________________________________
openssh-unix-dev at mindrot.org mailing list
http://www.mindrot.org/mailman/listinfo/openssh-unix-dev


***************************************************************************************
WARNING:  All e-mail sent to and from this address will be received or
otherwise recorded by the A.G. Edwards corporate e-mail system and is
subject to archival, monitoring or review by, and/or disclosure to,
someone other than the recipient.
***************************************************************************************
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20020128/ba348af0/attachment.html

> will adding -1 and -2 make people post useful patches for real
> bugs to this list?
I think your asking too much. =)

- Ben
Hating elm to death.

will adding -1 and -2 make people post useful patches for real
bugs to this list?

Nothing wrong with the code as much out our crappy implementation.  We've
got horrendous ssh_config and sshd_configs that don't integrate well with
each others or the OS's we support.  X11 forwarding is fundamentally broken,
paths are poor, uselogin is inconsistant, etc.  It's pretty much a recipe
for everyone avoiding ssh like the plague, esp since while info security and
my group (unix architecture) were wise enough to mandate that ssh must go on
all servers, they forgot to mandate that telnet, ftp, and r* had to come
off.  Plus the dunderheads in info security like obfuscation so much that
they mandated that we use a non-standard port which they were unfortunately
not clueful enough to avoid high ports, so it'd be trivial to for a normal
user to put a trojaned daemon on a box that's not running ssh.

*sigh*  Doing things right is a never-ending battle.

Thanks,
--Jason Lacoss-Arnold, Systems Technical Specialist
Technical Services - Unix Arch.
314-955-8501


-----Original Message-----
From: Markus Friedl [mailto:markus at openbsd.org]
Sent: Monday, January 28, 2002 11:20
To: Lacoss-Arnold, Jason
Cc: 'mouring'; Wichert Akkerman; openssh-unix-dev at mindrot.org
Subject: Re: [PATCH] Add scp -1 and -2 options to OpenSSH-3.0.2p1


On Mon, Jan 28, 2002 at 10:46:59AM -0600, Lacoss-Arnold, Jason
wrote:
> Personally, I wish it was in the current release as it'd greatly aid
our
> migration efforts (from a poorly done 2.5.1 implementation)
what's wrong with 2.5.1 ?
> and is a lot
> easier to communigate to clueless users.
> 
> We've finally managed to piggyback a real ssh deployment onto a high
profile
> project, and some of the user education is really sucking.
> 
> Thanks,
> --Jason Lacoss-Arnold, Systems Technical Specialist
> Technical Services - Unix Arch.
> 314-955-8501
> 
> 
> -----Original Message-----
> From: mouring [mailto:mouring at etoh.eviladmin.org]
> Sent: Monday, January 28, 2002 9:48
> To: Wichert Akkerman
> Cc: openssh-unix-dev at mindrot.org
> Subject: Re: [PATCH] Add scp -1 and -2 options to OpenSSH-3.0.2p1
> 
> 
> > Previously Markus Friedl wrote:
> > > why do you need -1 and -2?
> > 
> > Users want it, and it's very useful in situations where you need
> > to specifiy the version due to existing keys, old servers, etc.
> > 
> 
> #1 - OpenSSH/OpenBSD is not Debian.  What you do to the source is your 
> business, but you only add to the confusion (if there is any at all).  
> 
> #2 - In TWO years of helping people with ssh compiling, configuring, and
> using.  I've seen SIX people (80% of them are on this list!) whine
about
> lack of -1/-2.  The others where happy to use -oProtocol=[12] to do their
> job.
> 
> NOW please.. tell me.. *WHERE* are these MASSES of people crying out for
> the -1/-2 option for scp?  SIX people out of almost a thousand plus
> people I've interacted with.
> 
> <sigh>  Waste of time..
> 
> - Ben
> _______________________________________________
> openssh-unix-dev at mindrot.org mailing list
> http://www.mindrot.org/mailman/listinfo/openssh-unix-dev
> 
> 
>
****************************************************************************
***********
> WARNING:  All e-mail sent to and from this address will be received or
> otherwise recorded by the A.G. Edwards corporate e-mail system and is
> subject to archival, monitoring or review by, and/or disclosure to,
> someone other than the recipient.
>
****************************************************************************
***********


***************************************************************************************
WARNING:  All e-mail sent to and from this address will be received or
otherwise recorded by the A.G. Edwards corporate e-mail system and is
subject to archival, monitoring or review by, and/or disclosure to,
someone other than the recipient.
***************************************************************************************
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20020128/04f9a1b7/attachment.html