openssh unix dev - Mar 2001 - PAM and -u0

is this change ok?  goal is that PAM with -u0 does not use DNS (like
without PAM).

Index: auth-pam.c
==================================================================RCS file:
/var/cvs/openssh/auth-pam.c,v
retrieving revision 1.34
diff -u -r1.34 auth-pam.c
--- auth-pam.c	2001/03/27 06:12:24	1.34
+++ auth-pam.c	2001/03/30 16:46:12
@@ -41,6 +41,10 @@
 static int do_pam_conversation(int num_msg, const struct pam_message **msg,
 	struct pam_response **resp, void *appdata_ptr);

+/* XXX: move to header file */
+const char *
+get_remote_name_or_ip(void);
+
 /* module-local variables */
 static struct pam_conv conv = {
 	do_pam_conversation,
@@ -356,9 +360,9 @@
 		    pam_retval, PAM_STRERROR(__pamh, pam_retval));

 	debug("PAM setting rhost to \"%.200s\"",
-	    get_canonical_hostname(options.reverse_mapping_check));
+	    get_remote_name_or_ip());
 	pam_retval = pam_set_item(__pamh, PAM_RHOST,
-		get_canonical_hostname(options.reverse_mapping_check));
+	    get_remote_name_or_ip());
 	if (pam_retval != PAM_SUCCESS)
 		fatal("PAM set rhost failed[%d]: %.200s", pam_retval,
 		    PAM_STRERROR(__pamh, pam_retval));

On Fri, 30 Mar 2001, Kevin Steves wrote:
> is this change ok?  goal is that PAM with -u0 does not use DNS (like
> without PAM).
You should also remove the 'extern ServerOptions options;' from the
beginning of the function.
> +/* XXX: move to header file */
> +const char *
> +get_remote_name_or_ip(void);
Either that or add the remote host/address as an argument to start_pam()

-d

-- 
| Damien Miller <djm at mindrot.org> \ ``E-mail attachments are the poor
man's
| http://www.mindrot.org          /   distributed filesystem'' - Dan
Geer