openssh unix dev - Dec 2000 - OpenSSH-2.3.0p1 patch for yet another F-secure version

On Fri, 22 Dec 2000, Ramki Balasubramanian wrote:

[snip]
> server S/W version: SSH-2.0-2.1.0pl2
> server O/S version: SunOS 5.7 Generic_106541-11 sun4u sparc
[snip]
>   		{ "MindTerm",		0 },
>   		{ "^2\\.1\\.0 ",	SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
>   					SSH_OLD_SESSIONID },
> + /* yetanother 2.1.0 */
> + 		{ "^2\\.1\\.0.pl2 ",	SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
> + 					SSH_OLD_SESSIONID },
>   		{ "^2\\.0\\.",		SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
>   					SSH_OLD_SESSIONID|
>   					SSH_BUG_PUBKEYAUTH|SSH_BUG_X11FWD },
This has been fixed 3 weeks ago in CVS:

---
   - markus at cvs.openbsd.org 2000/12/03 11:27:55
     [compat.c]
     correctly match "2.1.0.pl2 SSH" etc; from
     pekkas at netcore.fi/bugzilla.redhat
---

CVS snapshots are available at http://bass.directhit.com/openssh_snap/

-- 
Pekka Savola                    "Tell me of difficulties surmounted,
Netcore Oy                      not those you stumble over and fall"
Systems. Networks. Security.     -- Robert Jordan: A Crown of Swords

Hi,

Here's a problem in openssh, some logs,
and a very minor patch that cures this:

Issue: (open)ssh client WILL NOT talk to F secure SSH-2.0-2.1.0pl2

client S/W version: openssh-2.3.0p1
client O/S version: SunOS 5.7 Generic_106541-11 sun4u sparc

server S/W version: SSH-2.0-2.1.0pl2
server O/S version: SunOS 5.7 Generic_106541-11 sun4u sparc 

Log/Details:

: % telnet <mymachine> 22
: Trying xx.xx.xx.xx...
: Connected to sd099001.
: Escape character is '^]'.
: SSH-2.0-2.1.0.pl2 SSH Secure Shell (non-commercial)

: % ssh <mymachine>
: ..
: autodetect SSH_BUG_SIGBLOB
: ..
: len 20 datafellows -2
:
: Received packet with bad string length ......
: ...DIES....

Actual problem:
	compat_datafellows() in compat.c does not recognize 2.1.0.pl2
    version of SSH as 2.1.0, so it sets the variable "datafellows"
	to the wrong value. This causes death.

one Working patch to the problem:
---------------------------------
 
*** compat.c	Sat Nov  4 21:42:36 2000
--- compat.c.new	Fri Dec 22 11:10:52 2000
***************
*** 66,71 ****
--- 66,74 ----
  		{ "MindTerm",		0 },
  		{ "^2\\.1\\.0 ",	SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
  					SSH_OLD_SESSIONID },
+ /* yetanother 2.1.0 */
+ 		{ "^2\\.1\\.0.pl2 ",	SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
+ 					SSH_OLD_SESSIONID },
  		{ "^2\\.0\\.",		SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
  					SSH_OLD_SESSIONID|
  					SSH_BUG_PUBKEYAUTH|SSH_BUG_X11FWD },