openssh unix dev - Oct 2000 - Typo in 2.2.0p1 ??

I don't already figure out what is the real impact of this but I think there
is
a typo in function sigchld_handler() in serverloop.c (l 75).

It is written

if (WIFEXITED(child_wait_status) ||
     WIFSIGNALED(child_wait_status))
     child_terminated = 1;
     child_has_selected = 0;

But I think one actually means:

if (WIFEXITED(child_wait_status) ||
     WIFSIGNALED(child_wait_status)) {
     child_terminated = 1;
     child_has_selected = 0;
}


Regards,

Philippe

On Fri, 27 Oct 2000, Philippe WILLEM wrote:
> I don't already figure out what is the real impact of this but I
> think there is a typo in function sigchld_handler() in serverloop.c
> (l 75).
>
> It is written
> 
> if (WIFEXITED(child_wait_status) ||
>      WIFSIGNALED(child_wait_status))
>      child_terminated = 1;
>      child_has_selected = 0;
> 
> But I think one actually means:
> 
> if (WIFEXITED(child_wait_status) ||
>      WIFSIGNALED(child_wait_status)) {
>      child_terminated = 1;
>      child_has_selected = 0;
> }
Quite so. Applied.

Thanks,
Damien Miller

-- 
| ``We've all heard that a million monkeys banging on | Damien Miller -
| a million typewriters will eventually reproduce the | <djm at
mindrot.org>
| works of Shakespeare. Now, thanks to the Internet, / 
| we know this is not true.'' - Robert Wilensky UCB /
http://www.mindrot.org