openssh unix dev - Apr 2000 - BUG: ssh-agent memory leak

Hey all!

I've been using OpenSSH on Linux since version 1.2.2; great work...

There is, however, a pretty noticable memory leak in ssh-agent.

I use ssh-agent to provide RSA authorization to automatically open an ssh
connection to download POP mail every three minutes.

When I was using the standard ssh-agent from 1.2.27 (not OpenSSH), I could
leave ssh-agent running for the entire uptime of my machine (typically
around 50 days at a time), and the process would take up about 500k, and
stay at that amount of memory usage.

OpenSSH's ssh-agent, however, will start at around that size, and then
while it's running, balloon in size. By 3 to 4 days of usage, the process
is sitting at around 10 megs; I actually forgot about the leak, and didn't
restart the daemon for about 10 days, and it was using about 35 megs up.
This was the case with both 1.2.2p1 and 1.2.3.

I'm not familiar with the source code, but I'd be happy to help in any
way
that I can...memory stats or whatever...I figure there's probably some
obvious free() that's not being done somewhere...

TIA.

Later,
Paul
  ------------------------------------------------------------------------
  J. Paul Reed                  preed at sigkill.com || www.sigkill.com/preed
  I used to be with it, but then they changed what "it" was. Now, what
I'm
  with isn't it, and what's "it" seems weird and scary to me. 
                                                         --Grandpa Simpson

On Sat, 29 Apr 2000, J. Paul Reed wrote:
> 
> Hey all!
> 
> I've been using OpenSSH on Linux since version 1.2.2; great work...
> 
> There is, however, a pretty noticable memory leak in ssh-agent.
Found and fixed in the next version. Here's a patch for now:

--- ssh-agent.c	2000/04/16 02:31:52	1.20
+++ ssh-agent.c	2000/04/21 05:55:21	1.23
@@ -440,6 +440,8 @@
 					shutdown(sockets[i].fd, SHUT_RDWR);
 					close(sockets[i].fd);
 					sockets[i].type = AUTH_UNUSED;
+					buffer_free(&sockets[i].input);
+					buffer_free(&sockets[i].output);
 					break;
 				}
 				buffer_consume(&sockets[i].output, len);
@@ -450,6 +452,8 @@
 					shutdown(sockets[i].fd, SHUT_RDWR);
 					close(sockets[i].fd);
 					sockets[i].type = AUTH_UNUSED;
+					buffer_free(&sockets[i].input);
+					buffer_free(&sockets[i].output);
 					break;
 				}
 				buffer_append(&sockets[i].input, buf, len);

-- 
| "Bombay is 250ms from New York in the new world order" - Alan Cox
| Damien Miller - http://www.mindrot.org/
| Email: djm at mindrot.org (home) -or- djm at ibs.com.au (work)