openssh bugs - Oct 2025 - [Bug 3874] New: Include <fcntl.h> explicitly in includes.h

https://bugzilla.mindrot.org/show_bug.cgi?id=3874

            Bug ID: 3874
           Summary: Include <fcntl.h> explicitly in includes.h
           Product: Portable OpenSSH
           Version: -current
          Hardware: All
                OS: FreeBSD
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Miscellaneous
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jlduran at gmail.com

Created attachment 3903
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3903&action=edit
FreeBSD patch

Obtained from FreeBSD. Verbatim commit message:

This was previously included due to nested includes in Heimdal's
headers.  Without this, the build fails with an error due to redefining
AT_FDCWD.

clang:

In file included from crypto/openssh/sshd-session.c:46:
/usr/obj/.../tmp/usr/include/fcntl.h:232:9: error: 'AT_FDCWD' macro
redefined [-Werror,-Wmacro-redefined]
  232 | #define AT_FDCWD                -100
      |         ^
crypto/openssh/openbsd-compat/bsd-misc.h:69:10: note: previous
definition is here
   69 | # define AT_FDCWD (-2)
      |          ^

GCC (can't be disabled):

In file included from crypto/openssh/sshd-session.c:46:
sys/sys/fcntl.h:232:9: error: "AT_FDCWD" redefined [-Werror]
  232 | #define AT_FDCWD                -100
      |         ^~~~~~~~
In file included from
crypto/openssh/openbsd-compat/openbsd-compat.h:218,
                 from crypto/openssh/includes.h:173,
                 from crypto/openssh/sshd-session.c:30:
openssh/openbsd-compat/bsd-misc.h:69:10: note: this is the location of
the previous definition
   69 | # define AT_FDCWD (-2)
      |          ^~~~~~~~

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3874

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net
   Attachment #3903|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #3903|0                           |1
           is patch|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3874

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
             Blocks|                            |3876

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Applied thanks, to both master and V_10_1 so it'll be in the next
release.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3876
[Bug 3876] Tracking bug for OpenSSH 10.2
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.