openssh bugs - Sep 2025 - [Bug 3859] New: Multiple occurences of MaxStartups are note processed in the order specified

https://bugzilla.mindrot.org/show_bug.cgi?id=3859

            Bug ID: 3859
           Summary: Multiple occurences of MaxStartups are note processed
                    in the order specified
           Product: Portable OpenSSH
           Version: 8.7p1
          Hardware: amd64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jan.v.hofmann at gmail.com

Hi,

when setting MaxStartups multiple times in sshd_config or included
files, I noticed that the last obtained value will be used, not the
first as is stated in the man pages. 

To reproduce, set in sshd_config:

MaxStartups 50:40:100
MaxStartups 100:30:1000

Then run `sshd -T | grep -i max` and you will see maxstartups
100:30:1000.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3859

--- Comment #1 from jan.v.hofmann at gmail.com ---
I noticed since, by looking at the source code, that other options seem
to behave in the same way and that this behavior is probably
intentional. However, it is confusing and should be documented.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3859

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org,
                   |                            |dtucker at dtucker.net
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
             Status|NEW                         |ASSIGNED
   Attachment #3896|                            |ok?(dtucker at dtucker.net)
              Flags|                            |

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Created attachment 3896
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3896&action=edit
Make MaxStartups and PerSourceMasklen idempotent

Good catch. This should fix it

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3859

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3896|ok?(dtucker at dtucker.net)    |ok+
              Flags|                            |

--- Comment #3 from Darren Tucker <dtucker at dtucker.net> ---
Comment on attachment 3896
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3896
Make MaxStartups and PerSourceMasklen idempotent

Hah I have almost the same diff here (except I added "rate" and
"begin"
variables, which makes the sscanf just fit on one line :-)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3859

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3808


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3808
[Bug 3808] Tracking bug for OpenSSH 10.1
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3859

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Multiple occurences of      |Multiple occurences of
                   |MaxStartups are note        |MaxStartups are not
                   |processed in the order      |processed in the order
                   |specified                   |specified

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3859

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Thanks, this has been committed as 683d0abe596b and will be in OpenSSH
10.1, due in ~1 month.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.