openssh bugs - May 2025 - [Bug 3821] New: Memory leak in agent_cleanup_stale

https://bugzilla.mindrot.org/show_bug.cgi?id=3821

            Bug ID: 3821
           Summary: Memory leak in agent_cleanup_stale
           Product: Portable OpenSSH
           Version: -current
          Hardware: amd64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh-agent
          Assignee: unassigned-bugs at mindrot.org
          Reporter: cmbugz at sent.com

I see this memory leak when running master (61525ba9):

14 bytes in 1 blocks are definitely lost in loss record 3 of 4
   at 0x48A67C2: malloc (vg_replace_malloc.c:446)
   by 0x4ED0B3F: __vasprintf_internal (vasprintf.c:116)
   by 0x4020E1B: xvasprintf (xmalloc.c:102)
   by 0x4020EFB: xasprintf (xmalloc.c:115)
   by 0x4012A7C: agent_cleanup_stale (misc-agent.c:290)
   by 0x400EB2B: main (ssh-agent.c:2424)


It looks like the prefix variable is not cleaned up in all branches:

290   xasprintf(&prefix, "s.%s.", path);

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3821

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3808
             Status|NEW                         |RESOLVED
                 CC|                            |djm at mindrot.org
         Resolution|---                         |FIXED

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Thanks, I've applied a fix.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3808
[Bug 3808] Tracking bug for OpenSSH 10.1
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.