openssh bugs - Sep 2024 - [Bug 3739] New: Match parsing requires space before '='

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

            Bug ID: 3739
           Summary: Match parsing requires space before '='
           Product: Portable OpenSSH
           Version: 9.9p1
          Hardware: amd64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: web-openssh at holm.dev

The man page for 'ssh_config(5)' says:
   Configuration options may be separated by whitespace or optional
whitespace and exactly one ?=?;
>From that I would expect this configuration to be valid:
  Match host="*.example.com,233.252.*"
          User usbpc

  Match host="*.example.com,!login.example.com" !exec="nc -z -w10
%h
22"
          ProxyJump login.example.com

However with v9.9p1 I get the following error:
  $ ssh -V
  OpenSSH_9.9p1, OpenSSL 3.3.2 3 Sep 2024
  $ ssh srv1.example.com
  Missing Match criteria for host=*.example.com,233.252.*
  /home/username/.ssh/config line 1: Bad Match condition
  Unsupported Match attribute host=*.example.com,!login.example.com
  /home/username/.ssh/config line 4: Bad Match condition
  /home/username/.ssh/config: terminating, 2 bad configuration options

The same configuration worked without a problem with v9.8p1
  $ ssh -V
  OpenSSH_9.8p1, OpenSSL 3.3.2 3 Sep 2024
  $ ssh srv.example.com
  Welcome to [...]

To get my configuration to work with v9.9p1 I need to replace the '='
with either a ' ' or ' =', so
  Match host "*.example.com,233.252.*"
or
  Match host ="*.example.com,233.252.*"
work.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

Kevin <web-openssh at holm.dev> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |web-openssh at holm.dev

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
                 CC|                            |djm at mindrot.org
             Status|NEW                         |ASSIGNED

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 3834
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3834&action=edit
allow Match criteria=arg

I wasn't aware that Match allowed '=' between the criteria and their
arguments, but I can see it was a side effect of the old lax tokeniser.

This patch should fix this.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Created attachment 3835
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3835&action=edit
revised diff

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3834|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3740


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3740
[Bug 3740] Tracking bug for OpenSSH 10.0
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net
   Attachment #3834|                            |ok?(dtucker at dtucker.net)
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3834|ok?(dtucker at dtucker.net)    |
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3835|                            |ok?(dtucker at dtucker.net)
              Flags|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Thanks for the report. This has been committed and also cherrypicked
onto the V_9_9 stable branch.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3739

--- Comment #4 from Kevin <web-openssh at holm.dev> ---
(In reply to Damien Miller from comment #3)
> Thanks for the report. This has been committed and also cherrypicked
> onto the V_9_9 stable branch.
Thanks for the quick response and modification of the new parser to
allow my unintended interpretation of the documentation for the config!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.