openssh bugs - Jul 2024 - [Bug 3707] New: Build failure on musl in ssh_systemd_notify (port-linux.c:369:25: error: passing argument 2 of 'connect' from incompatible pointer type)

https://bugzilla.mindrot.org/show_bug.cgi?id=3707

            Bug ID: 3707
           Summary: Build failure on musl in ssh_systemd_notify
                    (port-linux.c:369:25: error: passing argument 2 of
                    'connect' from incompatible pointer type)
           Product: Portable OpenSSH
           Version: 9.8p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: sam at gentoo.org

Originally reported downstream in Gentoo at
https://bugs.gentoo.org/935353.

```
port-linux.c: In function 'ssh_systemd_notify':
port-linux.c:369:25: error: passing argument 2 of 'connect' from
incompatible pointer type
[-Wincompatible-pointer-types[https://gcc.gnu.org/onlinedocs/gcc-14.1.0/gcc/Warning-Options.html#index-Wincompatible-pointer-types]]
  369 |         if (connect(fd, &addr, sizeof(addr)) != 0) {
      |                         ^~~~~
      |                         |
      |                         struct sockaddr_un *
In file included from ../includes.h:26,
                 from port-linux.c:22:                                 
                                                                       
                                         
/usr/include/sys/socket.h:386:19: note: expected 'const struct sockaddr
*' but argument is of type 'struct sockaddr_un *'
                                            386 | int connect (int,
const struct sockaddr *, socklen_t);
      |                   ^~~~~~~~~~~~~~~~~~~~~~~                       
```

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3707

--- Comment #1 from Sam James <sam at gentoo.org> ---
I should say, this is a musl-specific issue.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3707

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net

--- Comment #2 from Darren Tucker <dtucker at dtucker.net> ---
Created attachment 3823
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3823&action=edit
Cast sockaddr_un * to sockaddr *

This should fix it.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3707

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3708


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3708
[Bug 3708] Tracking bug for OpenSSH 9.9
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3707

--- Comment #3 from Sam James <sam at gentoo.org> ---
It does -- thank you!

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3707

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Darren Tucker <dtucker at dtucker.net> ---
Thanks for confirming.  I've committed this to both master and the
V_9_8 branch so it will be in the next release.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.