openssh bugs - Jun 2024 - [Bug 3697] New: session.c:709:3: error: call to undeclared function 'PRIVSEP';

https://bugzilla.mindrot.org/show_bug.cgi?id=3697

            Bug ID: 3697
           Summary: session.c:709:3: error: call to undeclared function
                    'PRIVSEP';
           Product: Portable OpenSSH
           Version: 9.7p1
          Hardware: ARM64
                OS: Mac OS X
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: artkiver at gmail.com

Created attachment 3815
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3815&action=edit
output from make which ends with errors generated as well as configure
parameters used to generate makefile for openssh-SNAP-2024-06-04 on
macOS 14.5

Testing openssh-SNAP-20240604.tar.gz on

macOS 14.5 23F79 arm64
Command Line Tools 15.3.0.0.1.1708646388

%make fails with:

session.c:709:3: error: call to undeclared function 'PRIVSEP'; ISO C99
and later do not support implicit function declarations
[-Wimplicit-function-declaration]
                PRIVSEP(audit_run_command(command));
                ^
session.c:709:11: error: argument type 'void' is incomplete
                PRIVSEP(audit_run_command(command));
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
session.c:715:11: error: argument type 'void' is incomplete
                PRIVSEP(audit_run_command(shell));
                        ^~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
make: *** [session.o] Error 1

More verbose configure and build log attached.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3697

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |djm at mindrot.org
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 3816
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3816&action=edit
remove obsolete PRIVSEP() macro use

Sorry about this - I missed these during the recent splitting of sshd.

This patch should fix it, though our test suite suggests there might
remain some problems on OSX wrt PAM that I haven't been able to
reproduce because I don't have a Mac ATM. You could see if these are a
problem using something like:

make t-exec TEST_SSH_SSHD_CONFOPTS='UsePam yes'

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3697

--- Comment #2 from ????grey? <artkiver at gmail.com> ---
(In reply to Damien Miller from comment #1)
> Created attachment 3816 [details]
> remove obsolete PRIVSEP() macro use
> 
> Sorry about this - I missed these during the recent splitting of
> sshd.
> 
> This patch should fix it, though our test suite suggests there might
> remain some problems on OSX wrt PAM that I haven't been able to
> reproduce because I don't have a Mac ATM. You could see if these are
> a problem using something like:
> 
> make t-exec TEST_SSH_SSHD_CONFOPTS='UsePam yes'
Thank you for the quick response!

Your patch seems to have at least resolved the challenges I had with
building.

% ./ssh -V
OpenSSH_9.7p1-snap20240604, LibreSSL 3.9.2

Admittedly, I don't use PAM on macOS/OS X either so much as I was using
./configure parameters cribbed from MacPorts' Portfile invocation (the
PAM related diff MacPorts' OpenSSH uses under /files/ predates my
maintainer volunteering as well, so I admit I have mostly just left it
alone).

I'll see if I can do some more testing, but for the time being if I
run:
%make t-exec TEST_SSH_SSHD_CONFOPTS='UsePam yes'

It hangs at the "run test connect.sh ...
ssh direct connect failed"

Possibly because I need to tweak my local firewall or some other
settings.

Regardless, thank you again for the quick diff fix!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.