openssh bugs - Feb 2022 - [Bug 3393] New: ssh_config: Overriding (local!) user shell

https://bugzilla.mindrot.org/show_bug.cgi?id=3393

            Bug ID: 3393
           Summary: ssh_config: Overriding (local!) user shell
           Product: Portable OpenSSH
           Version: 8.6p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: nhed+openssh-bugzilla22 at starry.com

We have a large shared ssh config that is shared between many
company employees.? A few of the entries have items like

? ? Host bla+*
? ? ? ? ProxyCommand ssh -q bla-jumpbox nc $(sed 's at bla+@@;
s at .blahnet@@'<<<%h).blahnet %p


Which usually works perfectly.? Today I learned that some users use
shells where this is not valid syntax (fish).

As a temporary workaround I advised the user to try to alias `ssh`
and `scp` so that they are prefixed with `SHELL=/bin/sh`.

Obviously we would make all of these wrapped with?`sh -c "...."`
but that will make the configs less readable?and we also would 
probably miss some because the user adding an entry is most likely
the rare `fish` user.

Suggestion: Add an ssh_config keyword such as `LocalShell` to 
override current logic when determining?local shell to use
when executing:
? ? - ProxyCommand,
? ? - LocalCommand, &
? ? - Match exec statements

NOTE: this is about the *LOCAL* (client side) shell.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3393

--- Comment #1 from Nevo Hed <nhed+openssh-bugzilla22 at starry.com> ---
Description Correction:

Replace

    ~adding an entry is most likely the rare `fish` user.~

with

    adding an entry is most likely *not* the rare `fish` user.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3393

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
I don't think we want another option for this, but we have fairly
recently renovated the quote handling in the config files so it's much
easier to quote these sorts of construction separately.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.