openssh bugs - Jun 2021 - [Bug 3319] New: ssh -o 'IPQoS cs1' cannot overwrite IPQoS in config file

https://bugzilla.mindrot.org/show_bug.cgi?id=3319

            Bug ID: 3319
           Summary: ssh -o 'IPQoS cs1' cannot overwrite IPQoS in config
                    file
           Product: Portable OpenSSH
           Version: 8.6p1
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: ypid at posteo.net

With a ~/.ssh/config like this:

Host *
    IPQoS af21 cs1


-o cannot overwrite IPQoS anymore:


ssh -o 'IPQoS cs1' gnu.example.net -G | grep -i ipqos
ipqos af21 cs1

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3319

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3302
                 CC|                            |dtucker at dtucker.net

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Confirmed, this is because the IPQoS config code does not check if the
value has already been set, which allows the values from the config
file to override it in readconf.c:

               if (*activep) {
                        options->ip_qos_interactive = value;
                        options->ip_qos_bulk = value2;
                }

It should also check options->ip_qos_interactive == -1.  A similar
problem exists for TunnelDevice.  A fix is in the pipeline and will be
in the next release.

Thanks for the report.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3302
[Bug 3302] Tracking bug for openssh-8.7
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3319

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Darren Tucker <dtucker at dtucker.net> ---
Fixed in
https://github.com/openssh/openssh-portable/commit/d786424986c04d1d375f231fda177c8408e05c3e
and
https://github.com/openssh/openssh-portable/commit/a023138957ea2becf1c7f93fcc42b0aaac6f2b03

Thanks.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3319

--- Comment #3 from Robin Schneider <ypid at posteo.net> ---
You are welcome. Thank you for maintaining and fixing this so quickly.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3319

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
closing bugs resolved before openssh-8.9

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.