bugzilla-daemon at mindrot.org
2021-Apr-27 01:39 UTC
[Bug 3305] New: keygen-comment.sh failure
https://bugzilla.mindrot.org/show_bug.cgi?id=3305
Bug ID: 3305
Summary: keygen-comment.sh failure
Product: Portable OpenSSH
Version: 8.6p1
Hardware: Other
OS: Windows 10
Status: NEW
Severity: minor
Priority: P5
Component: Regression tests
Assignee: unassigned-bugs at mindrot.org
Reporter: balu.gajjala at gmail.com
I'm using cygwin to test on my windows machine. keygen-comment.sh fails
at
https://github.com/openssh/openssh-portable/blob/77532609874a99a19e3e2eb2d1b7fa93aef963bb/regress/keygen-comment.sh#L14
$ egrep "^([0-9]+) SHA256:(.){43} ${comment} (.*)\$" ./ssh-ed25519-fgp
256 SHA256:LitlXmGRuL7VHjLgcZLMVa+OGnAZQZjypegmEFMZwZ0 foo bar
(ED25519)
Administrator at balu-saw
/cygdrive/c/Users/Administrator/Desktop/balu/openssh/code/master_branch/openssh-portable/regress/temp_test
$ egrep "^([0-9]+) SHA256:(.){43} ${comment} \(.*\)\$"
./ssh-ed25519-fgp
Administrator at balu-saw
/cygdrive/c/Users/Administrator/Desktop/balu/openssh/code/master_branch/openssh-portable/regress/temp_test
$ egrep -V
grep (GNU grep) 3.0
Packaged by Cygwin (3.0-2)
Copyright (C) 2017 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by Mike Haertel and others, see
<http://git.sv.gnu.org/cgit/grep.git/tree/AUTHORS>.
Administrator at balu-saw
/cygdrive/c/Users/Administrator/Desktop/balu/openssh/code/master_branch/openssh-portable/regress/temp_test
$
Code change -
from - if ! egrep "^([0-9]+) SHA256:(.){43} ${comment} \(.*\)\$" \
to - if ! egrep "^([0-9]+) SHA256:(.){43} ${comment} (.*)\$" \
--
You are receiving this mail because:
You are watching the assignee of the bug.
https://bugzilla.mindrot.org/show_bug.cgi?id=3305
balu <balu.gajjala at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |balu.gajjala at gmail.com
--
You are receiving this mail because:
You are watching the assignee of the bug.
https://bugzilla.mindrot.org/show_bug.cgi?id=3305
--- Comment #1 from balu <balu.gajjala at gmail.com> ---
Just to make it clear.
Without \, it works perfectly fine.
$ egrep "^([0-9]+) SHA256:(.){43} ${comment} (.*)\$" ./ssh-ed25519-fgp
256 SHA256:LitlXmGRuL7VHjLgcZLMVa+OGnAZQZjypegmEFMZwZ0 foo bar
(ED25519)
Administrator at balu-saw
/cygdrive/c/Users/Administrator/Desktop/balu/openssh/code/master_branch/openssh-portable/regress/temp_test
If I have \ (as in test cases) then it fails
$ egrep "^([0-9]+) SHA256:(.){43} ${comment} \(.*\)\$"
./ssh-ed25519-fgp
Administrator at balu-saw
/cygdrive/c/Users/Administrator/Desktop/balu/openssh/code/master_branch/openssh-portable/regress/temp_test
I have "egrep -V" output on my cygwin window in the issue description.
--
You are receiving this mail because:
You are watching the assignee of the bug.
https://bugzilla.mindrot.org/show_bug.cgi?id=3305 --- Comment #2 from balu <balu.gajjala at gmail.com> --- Created attachment 3503 --> https://bugzilla.mindrot.org/attachment.cgi?id=3503&action=edit Screenshot Attached is the screenshot that shows the cygwin output where test fails with egrep error. -- You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.mindrot.org/show_bug.cgi?id=3305
Darren Tucker <dtucker at dtucker.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dtucker at dtucker.net
--- Comment #3 from Darren Tucker <dtucker at dtucker.net> ---
We regularly test the main tree on Cygwin (current version as of a
couple of weeks ago) and it passes.
(In reply to balu from comment #1)> If I have \ (as in test cases) then it fails
[...]> I have "egrep -V" output on my cygwin window in the issue
> description.
Line continuation with a final backslash is a function of the shell,
not of grep.
Does your keygen-comment.sh contain only Unix-style newlines and not
Windows-style CR/NL ? I could imagine that causing a problem.
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
https://bugzilla.mindrot.org/show_bug.cgi?id=3305
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |djm at mindrot.org
Resolution|--- |WORKSFORME
Status|NEW |RESOLVED
--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Closing for lack of followup
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
https://bugzilla.mindrot.org/show_bug.cgi?id=3305
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #5 from Damien Miller <djm at mindrot.org> ---
closing bugs resolved before openssh-8.9
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.