openssh bugs - Dec 2020 - [Bug 3237] New: Regression in SSH_ASKPASS behavior

https://bugzilla.mindrot.org/show_bug.cgi?id=3237

            Bug ID: 3237
           Summary: Regression in SSH_ASKPASS behavior
           Product: Portable OpenSSH
           Version: 8.4p1
          Hardware: Other
                OS: Windows 10
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: dp.johnst at gmail.com

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3237

--- Comment #1 from Dylan Johnston <dp.johnst at gmail.com> ---
Apologies in advance if there is missing information here, as I am new
to OpenSSH. I'll do my best to provide as much information as possible.

Previously setting DISPLAY and SSH_ASKPASS would result in the
SSH_ASKPASS program to launch when shelling to SSH.

As of 8.4p1, this is no longer the case. SSH will instead fail to
launch the program defined by SSH_ASKPASS.

When I set `SSH_ASKPASS_REQUIRE` to `force`, it behaves as it did prior
to 8.4p1 (launches the SSH_ASKPASS program).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3237

--- Comment #2 from Dylan Johnston <dp.johnst at gmail.com> ---
I would also like to note that I am using OpenSSH via Git 2.29.2.
I am not running Git via the command line, but instead shelling to it
via a graphical application.

I am calling `git clone`, which is in turn calling OpenSSH.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3237

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
what are you setting DISPLAY to?

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3237

--- Comment #4 from Dylan Johnston <dp.johnst at gmail.com> ---
(In reply to Damien Miller from comment #3)
> what are you setting DISPLAY to?
Just an empty string (i.e. empty null terminated string when using
CreateProcessW on Windows).

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3237

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
Recent OpenSSH check that $DISPLAY is set to a non-empty string.

if you're on Windows, then you should probably use
SSH_ASKPASS_REQUIRE=force anyway because DISPLAY is nonsensical there
but otherwise you can get your old setup back by setting DISPLAY to a
non-empty string (anything will do).

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3237

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.