thr3ads.net - openssh bugs - [Bug 3135] New: SFTP Assumes quiet in batch mode - This regression breaks integration [Mar 2020]

If this information is useful, please help other people find it:
Share via:

bugzilla-daemon at bugzilla.mindrot.org

2020-Mar-12 23:21 UTC

[Bug 3135] New: SFTP Assumes quiet in batch mode - This regression breaks integration

https://bugzilla.mindrot.org/show_bug.cgi?id=3135

            Bug ID: 3135
           Summary: SFTP Assumes quiet in batch mode - This regression
                    breaks integration
           Product: Portable OpenSSH
           Version: 8.2p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: sftp
          Assignee: unassigned-bugs at mindrot.org
          Reporter: matt at roystontech.com.au

Prior to 2013, sftp in batch mode (-b) produced output that included
what was done. Quiet mode could be specified as well if desired.

Batch mode now assumes quiet mode and cannot be overridden.

This breaks integration which expects sftp output but uses batch mode.

Quiet as the default might be ok, but there is no way to 'unquiet'

I will be providing a pull on github that checks if quiet is set - if
it's not set, assume quiet, if it's set to no, honour that setting.
This provides the default functionality which is now current, but
provides the ability to override.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2020-Mar-13 00:01 UTC

head link

[Bug 3135] SFTP Assumes quiet in batch mode - This regression breaks integration

https://bugzilla.mindrot.org/show_bug.cgi?id=3135

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
I don't understand what you're referring to. sftp does produce output
by default in batch mode:

$ cat > /tmp/b
cd /bin
get ls /tmp
get xxls /tmp
$ sftp -b /tmp/b localhost
sftp> cd /bin
sftp> get ls /tmp
sftp> get xxls /tmp
File "/bin/xxls" not found.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2020-Mar-13 00:31 UTC

head link

[Bug 3135] SFTP Assumes quiet in batch mode - This regression breaks integration

https://bugzilla.mindrot.org/show_bug.cgi?id=3135

--- Comment #2 from Matthew Parslow <matt at roystontech.com.au> ---
It does have some output, but it's in quiet mode.

https://github.com/openssh/openssh-portable/commit/9303e6527bb5ca7630c765f28624702c212bfd6c?fbclid=IwAR3KCDxObbHrEBsHNUrHDxFfv4FT6wULg2udwPq6ZhPZvHkbwYdA2qbwnYI#diff-bfa9ee6de996100a65619653d189809fR2195
shows where it sets quiet mode.

example:

$ ls -lrt
total 0
$ cat /tmp/test/commands
ls /tmp/test/
get /tmp/test/*
$ sftp -b /tmp/test/commands testhost
sftp> ls /tmp/test
/tmp/test/1file   /tmp/test/2dir    /tmp/test/3file
sftp> get /tmp/test/*
Cannot download non-regular file: /tmp/test/2dir/
$ ls
1file  3file


Compare to:

matt at ludev:/tmp/dest$ sftp  testhost < /tmp/test/commands
Connected to testhost.
sftp> ls /tmp/test/
/tmp/test/1file     /tmp/test/2dir      /tmp/test/3file
sftp> get /tmp/test/*
Fetching /tmp/test/1file to 1file
Fetching /tmp/test/2dir/ to 2dir
Cannot download non-regular file: /tmp/test/2dir/
Fetching /tmp/test/3file to 3file

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2020-Mar-13 02:44 UTC

head link