openssh bugs - Nov 2019 - [Bug 3094] New: Signature verification fails on windows

https://bugzilla.mindrot.org/show_bug.cgi?id=3094

            Bug ID: 3094
           Summary: Signature verification fails on windows
           Product: Portable OpenSSH
           Version: 8.1p1
          Hardware: Other
                OS: Windows 10
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh-keygen
          Assignee: unassigned-bugs at mindrot.org
          Reporter: balu.gajjala at gmail.com

On windows, I tried to sign a file. The created signature file ends
with \r\n as it's windows. Then I tried to verify the signature. It
fails with the error message "Couldn't parse signature: missing
header".

==================Relevant Code
==================sshsig_dearmor() -> calls timingsafe_bcmp()
timingsafe_bcmp() -> This function fails as "\r\n" !=
"\n"
#define BEGIN_SIGNATURE         "-----BEGIN SSH SIGNATURE-----\n"

==================Steps:
==================PS E:\code\openssh-portable> get-content -raw .\version.h |
.\bin\x64\Debug\ssh-keygen.exe -vvv -Y sign -f .\id_rsa -n "abc" |
out-file .\id_rsa.sig


PS E:\code\openssh-portable> get-content -raw ./version.h |
.\bin\x64\Debug\ssh-keygen.exe -vvv -Y verify -s
E:\code\openssh-portable\id_rsa.sig -n "abc"  -f
E:\code\openssh-portable\id_rsa.pub -I test
Couldn't parse signature: missing header
verify: sshsig_armor: invalid format

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3094

balu <balu.gajjala at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |balu.gajjala at gmail.com
           Severity|enhancement                 |major
           Priority|P5                          |P3

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3094

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Native Windows is not a configuration supported by the OpenSSH team. 
Are you running the Microsoft fork?  If so you should report problems
directly to them.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3094

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
That being said, I think we should be insensitive to whitespace at EOL
in the header.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3094

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Created attachment 3348
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3348&action=edit
accept \r\n at end of signature banner

Please try this patch

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3094

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
This was fixed in openssh-9.5 (in commit 1ee0a16e07b6f0847)

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.