bugzilla-daemon at bugzilla.mindrot.org
2019-Nov-12 23:11 UTC
[Bug 3092] New: Inconsistent comment / code
https://bugzilla.mindrot.org/show_bug.cgi?id=3092
Bug ID: 3092
Summary: Inconsistent comment / code
Product: Portable OpenSSH
Version: 8.1p1
Hardware: Other
OS: Windows 10
Status: NEW
Severity: enhancement
Priority: P5
Component: sshd
Assignee: unassigned-bugs at mindrot.org
Reporter: balu.gajjala at gmail.com
Copied the code below. The else loop does the case sensitive (3rd
parameter is 0) match but the comment says it's case insensitive match.
In Match.c file
/* Match a list representing users or groups. */
int
match_usergroup_pattern_list(const char *string, const char *pattern)
{
#ifdef HAVE_CYGWIN
/* Windows usernames may be Unicode and are not case sensitive
*/
return cygwin_ug_match_pattern_list(string, pattern);
#else
/* Case insensitive match */
return match_pattern_list(string, pattern, 0);
#endif
}
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2019-Nov-12 23:15 UTC
[Bug 3092] Inconsistent comment / code
https://bugzilla.mindrot.org/show_bug.cgi?id=3092
balu <balu.gajjala at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |balu.gajjala at gmail.com
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2019-Nov-12 23:43 UTC
[Bug 3092] Inconsistent comment / code
https://bugzilla.mindrot.org/show_bug.cgi?id=3092
Darren Tucker <dtucker at dtucker.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Blocks| |3079
Status|NEW |RESOLVED
CC| |dtucker at dtucker.net
--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Fixed, thanks.
Referenced Bugs:
https://bugzilla.mindrot.org/show_bug.cgi?id=3079
[Bug 3079] Tracking bug for 8.2 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2019-Nov-14 00:03 UTC
[Bug 3092] Inconsistent comment / code
https://bugzilla.mindrot.org/show_bug.cgi?id=3092 --- Comment #2 from balu <balu.gajjala at gmail.com> --- Did you fix the comments or the code? -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2019-Nov-14 00:24 UTC
[Bug 3092] Inconsistent comment / code
https://bugzilla.mindrot.org/show_bug.cgi?id=3092 --- Comment #3 from Darren Tucker <dtucker at dtucker.net> --- Comment. Unix usernames are case sensitive. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug.
bugzilla-daemon at mindrot.org
2021-Apr-23 05:02 UTC
[Bug 3092] Inconsistent comment / code
https://bugzilla.mindrot.org/show_bug.cgi?id=3092
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #4 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.