openssh bugs - Aug 2019 - [Bug 3059] New: Typos and copy-paste errors in the code (openbsd-compat/bsd-misc.c)

https://bugzilla.mindrot.org/show_bug.cgi?id=3059

            Bug ID: 3059
           Summary: Typos and copy-paste errors in the code
                    (openbsd-compat/bsd-misc.c)
           Product: Portable OpenSSH
           Version: 8.0p1
          Hardware: Other
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Miscellaneous
          Assignee: unassigned-bugs at mindrot.org
          Reporter: samuel at cendio.se

Created attachment 3311
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3311&action=edit
Fix errors in openbsd-compat/bsd-misc.c

In the new code for 8.0 in openbsd-compat/bsd-misc.c in the functions
"fchownat" and "fchmodat" there are a number of errors:

In fchownat at line 178:

    # ifndef HAVE_FCHOWN
        return chown(pathname, owner, group);
    # else

There is no parameter called "pathname", it should simply be
"path"

Same goes for the function "fchmodat" at line 209:

    # ifndef HAVE_FCHOWN
        return chown(pathname, owner, group);
    # else

The parameter should be "path", and judging by the function name and
the ifndef, the call should probably be chmod instead:

    # ifndef HAVE_FCHMOD
        return chmod(path, mode);
    # else

Attached my patch.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3059

Samuel <samuel at cendio.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |samuel at cendio.se

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3059

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net
             Blocks|                            |2988


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2988
[Bug 2988] Tracking bug for 8.1 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3059

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Applied, thanks.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3059

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.