openssh bugs - May 2019 - [Bug 3014] New: [Enhancement] Tokens for RemoteForward - for unix sockets

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

            Bug ID: 3014
           Summary: [Enhancement] Tokens for RemoteForward - for unix
                    sockets
           Product: Portable OpenSSH
           Version: 8.0p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jirib79 at gmail.com

It would be great if tokens would work for RemoteForward keyword so one
could use them to define "dynamically" unix socket paths, for example
when running borg backup sw via unix sockets.

Example:

---%>---
Host *.example.com
  User backup
  Compression no
  Ciphers aes128-ctr
  MACs umac-64-etm at openssh.com
  IdentitiesOnly yes
  IdentityFile ~/.ssh/id_ed25519.%r%-example.com
  ExitOnForwardFailure yes
  StreamLocalBindUnlink yes
  RemoteForward /home/%r/tmp/borg.sock ~/tmp/%h-borg.sock # here!
  PermitLocalCommand yes
  LocalCommand socat UNIX-LISTEN:$HOME/tmp/%h-borg.sock "EXEC:borg
serve --append-only --restrict-to-path /borgbackup/example.com/%h
--umask 0007 --verbose" &
---%<---

And ssh command...

---%>---
export BACKUP_CLIENT=foo.example.com
export BACKUP_DOMAIN=$(echo ${BACKUP_CLIENT} | rev | cut -d'.' -f1-2 |
rev)
ssh -q ${BACKUP_CLIENT} "./bin/borgwrapper create --list -s
--exclude-caches
ssh://localhost/borgbackup/${BACKUP_DOMAIN}/${BACKUP_CLIENT}::'{now:%Y-%m-%dT%H:%M:%S}'
/" ; pkill -f "socat .*${BACKUP_CLIENT}"
---%<---

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

Jan Palus <jpalus at fastmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jpalus at fastmail.com

--- Comment #1 from Jan Palus <jpalus at fastmail.com> ---
*** Bug 3104 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

Luke <lukenbutters at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |P4
                 CC|                            |lukenbutters at gmail.com

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

--- Comment #2 from Daniel Kahn Gillmor <dkg at fifthhorseman.net> ---
*** Bug 3104 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

Daniel Kahn Gillmor <dkg at fifthhorseman.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dkg at fifthhorseman.net

--- Comment #3 from Daniel Kahn Gillmor <dkg at fifthhorseman.net> ---
see also #3140

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

Daniel Kahn Gillmor <dkg at fifthhorseman.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3140


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3140
[Bug 3140] support a token for XDG_RUNTIME_DIR
-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net

--- Comment #4 from Darren Tucker <dtucker at dtucker.net> ---
Created attachment 3371
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3371&action=edit
Add percent expansion to LocalForward and RemoteForward

The patch implements this on OpenBSD.  Unfortunately it relies on some
recent changes only in HEAD so it won't apply directly to any current
releases.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3117


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3117
[Bug 3117] Tracking bug for 8.3 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Darren Tucker <dtucker at dtucker.net> ---
This has been added and will be in the next major release.

Thanks.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3014

Ahmed Sayeed <ahmedsayeed1982 at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmedsayeed1982 at yahoo.com

--- Comment #7 from Ahmed Sayeed <ahmedsayeed1982 at yahoo.com> ---
In collect_register() function of arc-linux-tdep.c, the "eret"
http://www-look-4.com/travel/london/
(exception return) register value is not being reported correctly.

Background: https://komiya-dental.com/shopping/buy-android/
When asked for the "pc" value, we have to update the "eret"
register
with GDB's STOP_PC.  The "eret" instructs the kernel code where to
jump back http://www.iu-bloomington.com/shopping/hatchback-cars/ when
an instruction has stopped due to a breakpoint.  This
is how collect_register() is doing so:
https://waytowhatsnext.com/shopping/xbox-release-date/

--------------8<--------------
  if (regnum == gdbarch_pc_regnum (gdbarch))
http://www.wearelondonmade.com/travel/london/
    regnum = ARC_ERET_REGNUM;
  regcache->raw_collect (regnum, buf +
arc_linux_core_reg_offsets[regnum]);
-------------->8-------------- http://www.jopspeech.com/travel/london/

Root cause:
Although this is using the correct offset (ERET register's), it is also
http://joerg.li/travel/london/ 
changing the REGNUM itself.  Therefore, raw_collect (regnum, ...) is
not reading from "pc" anymore. http://connstr.net/travel/london/

Consequence:
This bug affects the "native ARC gdb" badly and causes kernel code to
jump
to addresses after the breakpoint and not executing the "breakpoint"ed
http://embermanchester.uk/travel/london/ 
instructions at all.  That "native ARC gdb" feature is not upstream
yet
and
is in review at the time of writing [1].
http://www.slipstone.co.uk/travel/london/
In collect_register() function of arc-linux-tdep.c, the "eret"
(exception return) register value is not being reported correctly.
http://www.logoarts.co.uk/travel/london/

Background:
When asked for the "pc" value, we have to update the "eret"
register
with GDB's STOP_PC. http://www.acpirateradio.co.uk/travel/good/  The
"eret" instructs the kernel code where to
jump back when an instruction has stopped due to a breakpoint.  This
is how collect_register() is doing so:
http://www.compilatori.com/travel/london/
--------------8<--------------
  if (regnum == gdbarch_pc_regnum (gdbarch))
    regnum = ARC_ERET_REGNUM;
  regcache->raw_collect (regnum, buf +
arc_linux_core_reg_offsets[regnum]);
-------------->8--------------

Root cause: https://www.webb-dev.co.uk/shopping/shopping-during-corona/
Although this is using the correct offset (ERET register's), it is also
changing the REGNUM itself.  Therefore, raw_collect (regnum, ...) is
not reading from "pc" anymore.

Consequence:
This bug affects the "native ARC gdb" badly and causes kernel code to
jump
to addresses after the breakpoint and not executing the "breakpoint"ed
instructions at all.  That "native ARC gdb" feature is not upstream
yet
and
is in review at the time of writing [1].

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.